Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the icon field entirely from the CSV #815

Merged

Conversation

mrkisaolamb
Copy link
Contributor

@mrkisaolamb mrkisaolamb commented Jul 8, 2024

As per an internal conversation, we are not authorized to use the upstream logo and we can save space by just removing the icon.

Related: OSPRH-8218

As per an internal conversation, we are not authorized to use the
upstream logo and we can save space by just removing the icon.
@mrkisaolamb mrkisaolamb requested a review from gibizer July 8, 2024 15:06
@openshift-ci openshift-ci bot requested review from lewisdenny and viroel July 8, 2024 15:06
@openshift-ci openshift-ci bot added the approved label Jul 8, 2024
@gibizer gibizer changed the title Remove the glance icon field entirely from the CSV Remove the icon field entirely from the CSV Jul 9, 2024
Copy link
Contributor

@gibizer gibizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to backport this to 18.0.0-proposed after this PR lands on main.

Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, mrkisaolamb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gibizer,mrkisaolamb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6752e8f into openstack-k8s-operators:main Jul 9, 2024
7 checks passed
@stuggi
Copy link
Contributor

stuggi commented Jul 10, 2024

/cherry-pick 18.0.0-proposed

@openshift-cherrypick-robot

@stuggi: new pull request created: #817

In response to this:

/cherry-pick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants