-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes config vars in nova.conf #823
Fixes config vars in nova.conf #823
Conversation
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/88f265c45dda4df79363394cf502c286 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 08m 51s |
recheck unrelated keystone 500 |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/051746defb7d4b469fd3400ac85b9510 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 54m 24s |
recheck unrelated fail, network create cmd failed with error:
Error while executing command: HttpException: 502, The server returned an invalid or incomplete response.: 502 Bad Gateway |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/29baff62dd7743c39141dd15fc44bf24 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 10m 32s |
templates/nova.conf
Outdated
state_path = /var/lib/nova | ||
instance_name_template = instance-%08x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the default value and i dont think we should be setting it here explicitly
its also used on the nova-api i think in some cases.
inanycase we should just remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
done, lest see how this goes with end ot end ci over all i think im happy with the current state
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/ba710462a36e438f826e5dd3a84f6ecc ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 45m 57s |
recheck unrealted |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/a99dac01908644a69000c018424dbbdc ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 00m 57s |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/7c720c20b925474db8f081ed1b2819e4 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 36m 14s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/4024c441027e479c8ecd6dfcda2b4894 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 31m 06s |
recheck |
#826 shows that we generate [libvirt] config section for the ironic compute config. So that config can be cleaned up too. |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/4cdbd27d5da342e187e61a3d004a0ac4 ✔️ openstack-k8s-operators-content-provider SUCCESS in 56m 44s |
by the way what is the motivation for this cleaning in general. we can make them conditional but I'm just wondering why the change of heart? |
good point. My goal is not to have misleading / unused config options in the service configs. If this leads to a complex template then I will probably propose to split the template to per service templates. |
ok because i really don't want to see use split this into multiple templates. its why we are intentionally not filtering which service config (cinder, neutorn) are generated to only some services. |
The cinder / neutron sections are less likely to cause a misunderstanding as they not expected to be configured by the user much. However something like |
recheck
it was using openstackclient for this, not sure, why it was creating a subnet it was not a tempest test. |
there are still lot of empty lines, because of how its rendered. as of now, I tried to use {% %}, but its just printing the whole thing and not parsing it as condition, so no change there. another way I tried for my tests is to refactor configData string to replace "\n\n\n+" with "\n", before writing to a final file, and it did the what we want, but this may not be a best way. |
we are not using jinia templating this is golang templating. there is a way to trim using - i.e. {{- -}} i belive see https://pkg.go.dev/text/template#hdr-Text_and_spaces for details. |
i woudl perfer to not include removing of extra white space in this pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one more nit to fix otherwise the generated config files looks good to me.
Also I'm OK to try to remove the excessive whitespaces from the generated config files in a separate commit.
/retest |
/retest
|
I rebased patch to contain fix for unstable tests, this should stabilize reconfiguration tests like "Nova reconfiguration [BeforeEach] reconfigures memcached service and check" |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/95fe2dc54e4c48f8821a2dab5b9e2bf9 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 34m 36s |
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like CI hiccups on timeouts in functionall test ended. I'm ok with this changes but @gibizer -1 so it will be nice to have his approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good thanks.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: auniyal61, gibizer, mrkisaolamb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest pod pending timeout, seems deployment issue |
@auniyal61: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test precommit-check |
2789586
into
openstack-k8s-operators:main
allow_resize_to_same_host
under nvoa-api[workarounds].disable_fallback_pcpu_query=true
under scheduler only and rest under nova-compute[libvirt] conf
underlibvirt.LibvirtDriver
driverCloses #144