Handle simulating conductor readiness #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like during some async operations we can simulate readines too fast. To avoid this issue we should handle this in eventually statement
SeanMooney
approved these changes
Jul 24, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrkisaolamb, SeanMooney The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit b2aa553
into
openstack-k8s-operators:main
6 checks passed
gibizer
reviewed
Jul 25, 2024
There was a problem hiding this comment.
Thanks @mrkisaolamb for making the job stable . Still we need to go back, understand and refactor how we simulate readyness as this is now all over the place and I'm afraid we will keep chasing similar issues as soon as a new change will be needed in the controllers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like during some async operations we
can simulate readines too fast. To avoid this issue we
should handle this in eventually statement