Update openstack-k8s-operators #843

openstack-k8s-ci-robot · 2024-08-10T05:00:30Z

This PR contains the following updates:

Package	Type	Update	Change
github.com/openstack-k8s-operators/infra-operator/apis	require	digest	`91b64b2` -> `12ffed6`
github.com/openstack-k8s-operators/keystone-operator/api	require	digest	`ba2309d` -> `990fe66`
github.com/openstack-k8s-operators/lib-common/modules/openstack	require	digest	`7fd3da6` -> `174296c`
github.com/openstack-k8s-operators/lib-common/modules/test	require	digest	`7fd3da6` -> `174296c`
github.com/openstack-k8s-operators/mariadb-operator/api	require	digest	`2d771bf` -> `64a741b`

Configuration

📅 Schedule: Branch creation - "every weekend" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

softwarefactory-project-zuul · 2024-08-10T08:34:01Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/62709f3b0d0640b3a0da84fdd233d330

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 32m 33s
✔️ nova-operator-kuttl SUCCESS in 46m 04s
❌ nova-operator-tempest-multinode TIMED_OUT in 3h 14m 40s
❌ nova-operator-tempest-multinode-ceph FAILURE in 1h 23m 43s

mrkisaolamb · 2024-08-19T15:11:53Z

/retest

mrkisaolamb · 2024-08-20T07:46:20Z

/retest-required

softwarefactory-project-zuul · 2024-08-20T12:16:17Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/576ebc76f8004dc49a2de4183c1a1442

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 44m 17s
✔️ nova-operator-kuttl SUCCESS in 39m 37s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 15m 31s
❌ nova-operator-tempest-multinode-ceph FAILURE in 1h 19m 39s

softwarefactory-project-zuul · 2024-08-21T17:31:36Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4b7f4a5617764ae78b52347a2ef91a54

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 28m 33s
✔️ nova-operator-kuttl SUCCESS in 39m 28s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 04m 39s
❌ nova-operator-tempest-multinode-ceph FAILURE in 1h 23m 44s

mrkisaolamb · 2024-08-22T13:41:44Z

recheck

mrkisaolamb · 2024-08-26T08:33:49Z

recheck

gibizer

OK we need this adaptation due to openstack-k8s-operators/lib-common@3824fa1

The controller change looks good to me, we want to set a condition. I have a suggestion to improve on the test assert.

gibizer · 2024-08-26T10:05:40Z

test/functional/novaapi_controller_test.go

@@ -933,13 +933,11 @@ var _ = Describe("NovaAPI controller", func() {
 		})

 		It("reports that the CA secret is missing", func() {
-			th.ExpectConditionWithDetails(
+			th.ExpectCondition(


Would be better to keep the detailed check. E.g. it shows that we basically lost a bit of details from the error message like the namespace of the secret, and the fact that what is missing is a Secret.

th.ExpectConditionWithDetails( novaNames.APIName, ConditionGetterFunc(NovaAPIConditionGetter), condition.TLSInputReadyCondition, corev1.ConditionFalse, condition.RequestedReason, "TLSInput is missing: combined-ca-bundle", )

gibizer · 2024-08-26T11:32:49Z

test/functional/nova_metadata_controller_test.go

-				condition.ErrorReason,
-				fmt.Sprintf("TLSInput error occured in TLS sources Secret %s/internal-tls-certs not found", novaNames.Namespace),
+				condition.RequestedReason,
+				"TLSInput is missing: combined-ca-bundle",


that seems to be a bug. This test case does create a the CA bunde, but does not create the internal tls cert.

Good catch, I differed errors by using "one or more cert secrets" error log like other operators do (to be consistent) but if we want be more specific we can go with separate errors for internal and vencrypt cert

gibizer · 2024-08-26T11:33:03Z

test/functional/nova_novncproxy_test.go

-				condition.ErrorReason,
-				fmt.Sprintf("TLSInput error occured in TLS sources Secret %s/internal-tls-certs not found", novaNames.Namespace),
+				condition.RequestedReason,
+				"TLSInput is missing: combined-ca-bundle",


gibizer · 2024-08-26T11:33:21Z

test/functional/nova_novncproxy_test.go

-				condition.ErrorReason,
-				fmt.Sprintf("TLSInput error occured in TLS sources Secret %s/vencrypt-tls-certs not found", novaNames.Namespace),
+				condition.RequestedReason,
+				"TLSInput is missing: combined-ca-bundle",


gibizer · 2024-08-26T11:33:30Z

test/functional/nova_novncproxy_test.go

-				condition.ErrorReason,
-				fmt.Sprintf("TLSInput error occured in TLS sources Secret %s/internal-tls-certs not found", novaNames.Namespace),
+				condition.RequestedReason,
+				"TLSInput is missing: combined-ca-bundle",


gibizer · 2024-08-26T11:33:43Z

test/functional/nova_novncproxy_test.go

-				condition.ErrorReason,
-				fmt.Sprintf("TLSInput error occured in TLS sources Secret %s/vencrypt-tls-certs not found", novaNames.Namespace),
+				condition.RequestedReason,
+				"TLSInput is missing: combined-ca-bundle",


gibizer · 2024-08-26T11:34:02Z

test/functional/novaapi_controller_test.go

-				condition.ErrorReason,
-				fmt.Sprintf("TLSInput error occured in TLS sources Secret %s/internal-tls-certs not found", novaNames.Namespace),
+				condition.RequestedReason,
+				"TLSInput is missing: combined-ca-bundle",


gibizer · 2024-08-26T11:34:08Z

test/functional/novaapi_controller_test.go

-				condition.ErrorReason,
-				fmt.Sprintf("TLSInput error occured in TLS sources Secret %s/public-tls-certs not found", novaNames.Namespace),
+				condition.RequestedReason,
+				"TLSInput is missing: combined-ca-bundle",


gibizer · 2024-08-26T15:29:45Z

controllers/novaapi_controller.go

+			condition.TLSInputReadyCondition,
+			condition.RequestedReason,
+			condition.SeverityInfo,
+			fmt.Sprintf(condition.TLSInputReadyWaitingMessage, "one or more cert secrets")))


Yeah this is what I commented about during our call. In the past the error we get from the lib-common stated which secret was missing but now we don't know that exactly if the internal or the public tls cert is missing. This should be fixed in lib-common as this makes it impossible to us to tell the user which secret is missing via the condition.

As this was changed in openstack-k8s-operators/lib-common#547 by @abays lets see what he suggest.

yes agree that we now missing info about what service secret is missing, but it's hard to find a way to inform user more specific than adding additional info what secrets we are require for service (public and/or internal)

softwarefactory-project-zuul · 2024-08-26T16:29:22Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/20d58766de344f6fa654afa566ceda72

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 22m 29s
✔️ nova-operator-kuttl SUCCESS in 38m 15s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 02m 56s
❌ nova-operator-tempest-multinode-ceph FAILURE in 1h 20m 40s

rebtoor · 2024-08-28T09:27:46Z

recheck

requested autohold on node

softwarefactory-project-zuul · 2024-08-28T12:00:40Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/24d7d0ceefd44958a88e51a54eb45fcf

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 30m 25s
✔️ nova-operator-kuttl SUCCESS in 40m 41s
✔️ nova-operator-tempest-multinode SUCCESS in 1h 52m 17s
❌ nova-operator-tempest-multinode-ceph FAILURE in 1h 18m 11s

rebtoor · 2024-08-28T13:02:04Z

recheck

autohold (now with the right project 🤦🏻‍♂️ )

softwarefactory-project-zuul · 2024-09-07T13:43:54Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bccf9c9437654bd3b2a7aab98961baf1

✔️ openstack-meta-content-provider SUCCESS in 3h 03m 29s
✔️ nova-operator-kuttl SUCCESS in 40m 32s
❌ nova-operator-tempest-multinode FAILURE in 1h 59m 32s
✔️ nova-operator-tempest-multinode-ceph SUCCESS in 2h 46m 52s

gibizer · 2024-09-09T08:24:08Z

/recheck
There are http 504 errors from nova in the tempes logs. I don't see any real failure in the nova-api / apache logs so I assume this was some overload on the infra side.

openshift-ci · 2024-09-09T08:24:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, openstack-k8s-ci-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [gibizer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot requested review from SeanMooney and viroel August 10, 2024 05:00

openstack-k8s-ci-robot force-pushed the renovate/openstack-k8s-operators branch from f90db8f to 8416bb7 Compare August 17, 2024 04:40

mrkisaolamb force-pushed the renovate/openstack-k8s-operators branch from 8416bb7 to 9dec273 Compare August 20, 2024 09:28

openshift-merge-robot added the needs-rebase label Aug 21, 2024

mrkisaolamb force-pushed the renovate/openstack-k8s-operators branch from 9dec273 to bfb5fa3 Compare August 21, 2024 15:02

openshift-merge-robot removed the needs-rebase label Aug 21, 2024

gibizer requested changes Aug 26, 2024

View reviewed changes

openshift-ci bot assigned gibizer Aug 26, 2024

mrkisaolamb force-pushed the renovate/openstack-k8s-operators branch from bfb5fa3 to 08c2cfc Compare August 26, 2024 10:55

gibizer requested changes Aug 26, 2024

View reviewed changes

mrkisaolamb force-pushed the renovate/openstack-k8s-operators branch from 08c2cfc to 6046be0 Compare August 26, 2024 14:02

gibizer requested changes Aug 26, 2024

View reviewed changes

mrkisaolamb requested a review from abays August 27, 2024 11:52

openshift-merge-robot added the needs-rebase label Sep 3, 2024

Update openstack-k8s-operators

ceead51

openstack-k8s-ci-robot force-pushed the renovate/openstack-k8s-operators branch from 6046be0 to ceead51 Compare September 7, 2024 10:39

openshift-merge-robot removed the needs-rebase label Sep 7, 2024

gibizer approved these changes Sep 9, 2024

View reviewed changes

openshift-ci bot added the lgtm label Sep 9, 2024

openshift-ci bot added the approved label Sep 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update openstack-k8s-operators #843

Update openstack-k8s-operators #843

openstack-k8s-ci-robot commented Aug 10, 2024 •

edited

Loading

softwarefactory-project-zuul bot commented Aug 10, 2024

mrkisaolamb commented Aug 19, 2024

mrkisaolamb commented Aug 20, 2024

softwarefactory-project-zuul bot commented Aug 20, 2024

softwarefactory-project-zuul bot commented Aug 21, 2024

mrkisaolamb commented Aug 22, 2024

mrkisaolamb commented Aug 26, 2024

gibizer left a comment

gibizer Aug 26, 2024

mrkisaolamb Aug 26, 2024

gibizer Aug 26, 2024

mrkisaolamb Aug 26, 2024

gibizer Aug 26, 2024

gibizer Aug 26, 2024

gibizer Aug 26, 2024

gibizer Aug 26, 2024

gibizer Aug 26, 2024

gibizer Aug 26, 2024

gibizer Aug 26, 2024

mrkisaolamb Aug 27, 2024

softwarefactory-project-zuul bot commented Aug 26, 2024

rebtoor commented Aug 28, 2024

softwarefactory-project-zuul bot commented Aug 28, 2024

rebtoor commented Aug 28, 2024

softwarefactory-project-zuul bot commented Sep 7, 2024

gibizer commented Sep 9, 2024

openshift-ci bot commented Sep 9, 2024

Update openstack-k8s-operators #843

Are you sure you want to change the base?

Update openstack-k8s-operators #843

Conversation

openstack-k8s-ci-robot commented Aug 10, 2024 • edited Loading

Configuration

softwarefactory-project-zuul bot commented Aug 10, 2024

mrkisaolamb commented Aug 19, 2024

mrkisaolamb commented Aug 20, 2024

softwarefactory-project-zuul bot commented Aug 20, 2024

softwarefactory-project-zuul bot commented Aug 21, 2024

mrkisaolamb commented Aug 22, 2024

mrkisaolamb commented Aug 26, 2024

gibizer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Aug 26, 2024

rebtoor commented Aug 28, 2024

softwarefactory-project-zuul bot commented Aug 28, 2024

rebtoor commented Aug 28, 2024

softwarefactory-project-zuul bot commented Sep 7, 2024

gibizer commented Sep 9, 2024

openshift-ci bot commented Sep 9, 2024

openstack-k8s-ci-robot commented Aug 10, 2024 •

edited

Loading