Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up volumes list for ovn-controller pod #182

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Clean up volumes list for ovn-controller pod #182

wants to merge 6 commits into from

Commits on Jan 4, 2024

  1. Squash configJob into ovn-controller pod 

    This allows to get rid of a hostMount shared between the job pod and the
main ovsdb-server pod container (to enable communication of vsctl
command with the database socket).

Getting rid of hostMounts is needed to be able to eventually stop
running ovn-controller pods as privileged containers.
    @booxter
    booxter committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    915b67b View commit details
    Browse the repository at this point in the history

  2. Switch ovn-controller:var-run volume to emptyDir 

    This is to prove that this is possible, now that configJob is squashed
into the main ovn-controller pod.
    @booxter
    booxter committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    97f766c View commit details
    Browse the repository at this point in the history

  3. Remove unneeded localtime and machine-id volumes

    @booxter
    booxter committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    4d4147d View commit details
    Browse the repository at this point in the history

  4. Remove log hostpath mounts for ovn-controller 

    We log to stdout. Nothing else is needed.
    @booxter
    booxter committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    7572c99 View commit details
    Browse the repository at this point in the history

  5. Remove /var/run/ovn hostPath mount 

    This directory can be local to the container and does not need to
persist.

Note the rundir directory is not present in the image, so we have to
switch OVN_RUNDIR to point to /tmp, same as we do for other ovn services
managed by the operator.
    @booxter
    booxter committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    87ca3ca View commit details
    Browse the repository at this point in the history

  6. Remove var-lib hostMount from ovn-controller pod 

    I am not aware of anything using the directory.
    @booxter
    booxter committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    a76e967 View commit details
    Browse the repository at this point in the history