Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch ovn-controller to StatefulSets #183

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

booxter
Copy link
Contributor

@booxter booxter commented Dec 15, 2023

No description provided.

Copy link
Contributor

openshift-ci bot commented Dec 15, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Dec 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: booxter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@booxter
Copy link
Contributor Author

booxter commented Dec 15, 2023

Note: most of the patches here come from a different "dependent" series posted elsewhere. (Github doesn't support dependencies, sorry.)

This allows to get rid of a hostMount shared between the job pod and the
main ovsdb-server pod container (to enable communication of vsctl
command with the database socket).

Getting rid of hostMounts is needed to be able to eventually stop
running ovn-controller pods as privileged containers.
This is to prove that this is possible, now that configJob is squashed
into the main ovn-controller pod.
We log to stdout. Nothing else is needed.
This directory can be local to the container and does not need to
persist.

Note the rundir directory is not present in the image, so we have to
switch OVN_RUNDIR to point to /tmp, same as we do for other ovn services
managed by the operator.
I am not aware of anything using the directory.
TODO:
- anti-affinity rule
- expose storageClass?
- maintain the proper number of replicas
@booxter booxter force-pushed the statefulset-for-ovn-controller branch from 583213f to 89c523f Compare January 4, 2024 22:57
@booxter
Copy link
Contributor Author

booxter commented Jan 4, 2024

/ok-to-test

Copy link
Contributor

openshift-ci bot commented Jan 4, 2024

@booxter: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional 89c523f link true /test functional
ci/prow/ovn-operator-build-deploy-kuttl 89c523f link true /test ovn-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants