Retrieve DNS domain name from cluster #258
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: averdagu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| // Using this approach in case CP have multiple domains | ||
| // also it does not depend on the DNS CR name. | ||
| // ATM in case of multiple domains will return last one. | ||
| for _, dns := range DNSClusterInfoList.Items { | ||
| DNSDomain = dns.Status.ClusterDomain | ||
| } |
There was a problem hiding this comment.
I don't know if it's possible or if it'll be a use case the fact that exists multiple DNS domains (besides cluster.local) and how OVN operator should handle it
There was a problem hiding this comment.
Looking at the Reconcile loop of the openshift dns-operator, it only expects a DNS CR named Default, Could modify this chunk of code to get the object by name instead of getting a list and iterating over it.
https://github.com/openshift/cluster-dns-operator/blob/master/pkg/operator/controller/controller.go#L180-L184
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/2f28d7cb69234cb9b0e139a543d6f205 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 24m 11s |
averdagu
force-pushed
the
fix/get_dns_cluster_info
branch
from
a59fc64
to
930f64d
Compare
Jira: OSPRH-3627
averdagu
force-pushed
the
fix/get_dns_cluster_info
branch
from
930f64d
to
2bb41ba
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/3d820c03902b4db08044c0e7f22d5129 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 08m 16s |
Jira: OSPRH-3627