Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: capitalize OVS and OVN in variable names and elsewhere #287

Merged
merged 2 commits into from
Jun 7, 2024
Merged

style: capitalize OVS and OVN in variable names and elsewhere #287

merged 2 commits into from
Jun 7, 2024

Conversation

booxter
Copy link
Contributor

@booxter booxter commented May 17, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from beagles and lewisdenny May 17, 2024 19:52
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/c4fadb82e9ac4e2fb73b5e813a0a1e24

❌ openstack-k8s-operators-content-provider FAILURE in 11m 42s
⚠️ ovn-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@lewisdenny lewisdenny removed their request for review May 20, 2024 23:22
@booxter
Copy link
Contributor Author

booxter commented Jun 3, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ovn-operator for 287,91e8515f82ed91bc00e4294616771c6d2512fb98

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9cddc183bf3c45a69b6199dcdc1cc8e6

❌ openstack-k8s-operators-content-provider FAILURE in 11m 25s
⚠️ ovn-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@booxter
Temporarily add ServiceNameOvnNorthd and ServiceNameOvnController
f4215f8 
These are used in openstack-operator tree. We'll remove them once
openstack-operator switches to the new upper cased symbols.
karelyatin
karelyatin approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@karelyatin karelyatin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: booxter, karelyatin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0499041 into openstack-k8s-operators:main Jun 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karelyatin karelyatin karelyatin approved these changes

@beagles beagles Awaiting requested review from beagles

Assignees

@karelyatin karelyatin

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@booxter @karelyatin @openshift-merge-robot