-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non graceful OVN DB pod delete Kuttl test #299
Remove non graceful OVN DB pod delete Kuttl test #299
Conversation
30e8cdf
to
bee0787
Compare
Seems the timeout needs to be increased to add a timeout -_-, can't find any docs but [1] |
bee0787
to
a335954
Compare
Addition of test case for --force --grace-period 0 was a mistake. This won't kill ovsdb-server, which will leave db file locked. This scenario is invalid to test - force delete should be used only when node is completely dead, I don't think we can emulate it in kuttl. Please just remove the whole test case instead. |
tests/kuttl/tests/ovn_db_delete/06-delete-pods-non-graceful.yaml
Outdated
Show resolved
Hide resolved
We are seeing a failure with the `06-delete-pods-non-graceful.yaml` job in OCP 4.15 Prow CI. After discussing with the ovn-operator maintainers we decided this test is invalid. With both `--force` and `--grace-period=0` the database lock file is not being released and this is something that requires hands on recovery which isn't being covered in this test case. JIRA: https://issues.redhat.com/browse/OSPRH-7515
a335954
to
0c7af4e
Compare
/retest Seems pvc failed to terminate
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karelyatin, lewisdenny The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2847b4c
into
openstack-k8s-operators:main
We are seeing a failure with the
06-delete-pods-non-graceful.yaml
jobin OCP 4.15 Prow CI. After discussing with the ovn-operator maintainers
we decided this test is invalid. With both
--force
and--grace-period=0
the database lock file is not being released and thisis something that requires hands on recovery which isn't being covered in
this test case.
JIRA: https://issues.redhat.com/browse/OSPRH-7515