Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make bundle to pre-commit #304

Conversation

booxter
Copy link
Contributor

@booxter booxter commented Jun 10, 2024

This will ensure to get csv updates together with the changes.

This is verbatim copy from neutron-operator: openstack-k8s-operators/neutron-operator#323

@openshift-ci openshift-ci bot requested review from abays and beagles June 10, 2024 20:27
Copy link
Contributor

openshift-ci bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: booxter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@booxter
Copy link
Contributor Author

booxter commented Jun 10, 2024

I expect it to fail until #303 is merged.

This will ensure to get csv updates together with the changes.
Copy link
Contributor

@karelyatin karelyatin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 62d4b4e into openstack-k8s-operators:main Jun 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants