Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NAD handling on create/update #305

Merged

Conversation

karelyatin
Copy link
Contributor

@karelyatin karelyatin commented Jun 12, 2024

Currently only NAD creation was handled for the provided
nicMappings, this patch allows update to the nads.

Added missing ownership to the managed net-attach-defs
so they get's controlled with OVNController reconciler if
deleted/updated explicitly.

Also added functional tests and fixed some log messages.

Closes-Issue: OSPRH-6894

@openshift-ci openshift-ci bot requested review from slawqo and viroel June 12, 2024 15:29
Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karelyatin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@booxter booxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, just nits + please add func tests for the scenarios.

pkg/ovncontroller/network.go Outdated Show resolved Hide resolved
pkg/ovncontroller/network.go Outdated Show resolved Hide resolved
Currently only NAD creation was handled for the provided
nicMappings, this patch allows update to the nads.

Added missing ownership to the managed net-attach-defs
so they get's controlled with OVNController reconciler if
deleted/updated explicitly.

Also added functional tests and fixed some log messages.

Closes-Issue: OSPRH-6894
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/cae020714340408d896203c7e8703efa

openstack-k8s-operators-content-provider FAILURE in 14m 30s
⚠️ ovn-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@karelyatin
Copy link
Contributor Author

recheck quay registry issue

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b7787fcd71f347d0902fc077b639f467

openstack-k8s-operators-content-provider FAILURE in 8m 12s
⚠️ ovn-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@karelyatin
Copy link
Contributor Author

recheck #306

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1259a1a644214aee8b897180b01ddc04

openstack-k8s-operators-content-provider FAILURE in 8m 48s
⚠️ ovn-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@karelyatin
Copy link
Contributor Author

recheck #306

@booxter
Copy link
Contributor

booxter commented Jun 14, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit cbe8d2b into openstack-k8s-operators:main Jun 14, 2024
6 checks passed
@karelyatin karelyatin deleted the OSPRH-6894 branch June 24, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants