-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NAD handling on create/update #305
Fix NAD handling on create/update #305
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karelyatin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct, just nits + please add func tests for the scenarios.
Currently only NAD creation was handled for the provided nicMappings, this patch allows update to the nads. Added missing ownership to the managed net-attach-defs so they get's controlled with OVNController reconciler if deleted/updated explicitly. Also added functional tests and fixed some log messages. Closes-Issue: OSPRH-6894
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/cae020714340408d896203c7e8703efa ❌ openstack-k8s-operators-content-provider FAILURE in 14m 30s |
recheck quay registry issue |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/b7787fcd71f347d0902fc077b639f467 ❌ openstack-k8s-operators-content-provider FAILURE in 8m 12s |
recheck #306 |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/1259a1a644214aee8b897180b01ddc04 ❌ openstack-k8s-operators-content-provider FAILURE in 8m 48s |
recheck #306 |
/lgtm |
cbe8d2b
into
openstack-k8s-operators:main
Currently only NAD creation was handled for the provided
nicMappings, this patch allows update to the nads.
Added missing ownership to the managed net-attach-defs
so they get's controlled with OVNController reconciler if
deleted/updated explicitly.
Also added functional tests and fixed some log messages.
Closes-Issue: OSPRH-6894