Stop the OVN database during the cleanup script

[ralonsoh]

Closes-Issue: OSPRH-8118

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ralonsoh
Once this PR has been reviewed and has the lgtm label, please assign dprince for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @ralonsoh. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[olliewalsh]

/ok-to-test

[olliewalsh]

Closes-Issue: OSPRH-8118

How about just removing --single-child from the dumb-init args so it sends SIGTERM to the entire process group?

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/570d19d95a2e44c0ad8896e7ebaeb63c

✔️ openstack-k8s-operators-content-provider SUCCESS in 40m 51s
❌ ovn-operator-tempest-multinode RETRY_LIMIT in 23m 03s

[booxter]

you can just stop_${DB_TYPE}_ovsdb I think.

[booxter]

@olliewalsh the problem with (just) removing --single-child is that dumb-init won't wait for children-of-children to exit, it will only wait for the start script to exit. (And the latter will exit immediately because there's no trap set for SIGTERM there to e.g. wait for dbserver to exit.) - Alternative solution could be to implement SIGTERM handler in the start script.

[booxter]

@olliewalsh btw FYI the signal handling improvement is tracked here: https://issues.redhat.com/browse/OSPRH-8212

[ralonsoh]

@olliewalsh btw FYI the signal handling improvement is tracked here: https://issues.redhat.com/browse/OSPRH-8212

If we are going to implement this signal handler in the start script, is this patch relevant anymore?

[ralonsoh]

/test ovn-operator-build-deploy-kuttl

[ralonsoh]

/test ovn-operator-build-deploy-kuttl

[booxter]

If we are going to implement this signal handler in the start script, is this patch relevant anymore?

I think it depends on how the signal handler would be implemented. The handler could handle this job, or it could only take care about ovsdb-tool db initialization. (Which is the original scenario that spurred these Jira issues.)

But yes, I think everything could be handled inside the signal handler.

[openshift-ci]

@ralonsoh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ovn-operator-build-deploy-kuttl	690a938	link	true	/test ovn-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ralonsoh]

This patch is hitting several issues:

• https://issues.redhat.com/browse/OSPRH-7626. This bug is describing what is happening during the deletion of the OVNDBCluster pods.
• This patch is always stopping the ovsdb-server regardless of the ovsdb-server status. We can check first if the DB is still running.