-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary rights #267
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lpiwowar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
recheck |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
This PR will be rebased and ready for a review once this PR gets merged -> #266 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the requested change, I was not able to run the change properly. Other than that, the patch seems to be working.
In this PR [1] we dropped the usage of the Jobs by the test-operator. This allows us to drop the rights for: - ServiceAccount managing & creation - Role managing & creation - RoleBinding managing & creation These rights were only needed because Jobs were required to be spawned with an extra ServiceAccount that would have elevated privileges in case the test pods need to run with privileged SecurityContext. [1] openstack-k8s-operators#266 Depends-On: openstack-k8s-operators#266
4eaae56
to
2ce2ac5
Compare
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you:)
@kstrenkova just FYI: [1] #267 (comment) |
In this PR [1] we dropped the usage of the Jobs by the test-operator.
This allows us to drop the rights for:
These rights were only needed because Jobs were required to be spawned
with an extra ServiceAccount that would have elevated privileges in case
the test pods need to run with privileged SecurityContext.
[1] #266
Depends-On: #266