Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional parameters for HorizonTest #276

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ashu-011
Copy link
Contributor

@ashu-011 ashu-011 commented Feb 4, 2025

This PR adds additional paramaters to horizontest CR in order to modify the pytest command and projectname xpath based on upstream and downstream dashboard theme

Copy link

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ashu-011
Once this PR has been reviewed and has the lgtm label, please assign abays for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c05efe01cfd64f9d931e6a54cf494eb9

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 22m 23s
podified-multinode-edpm-deployment-crc-test-operator FAILURE in 2h 09m 46s

@ashu-011 ashu-011 force-pushed the add_horizon_param branch 2 times, most recently from 8dc2675 to 0bf8770 Compare February 4, 2025 21:16
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/192848d725a243748492a45eb0cbd1d7

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 43m 07s
podified-multinode-edpm-deployment-crc-test-operator FAILURE in 2h 21m 43s

@ashu-011
Copy link
Contributor Author

ashu-011 commented Feb 6, 2025

recheck

This PR adds additional paramaters to horizontest CR in order to modify
the pytest command and projectname xpath based on upstream and
downstream dashboard theme
@kstrenkova
Copy link
Contributor

To me, the patch seems to be working. I tried to run horizon tests and it does not create any errors. The code looks correct from the logic and structure perspective as well. After merging the change in tcib, I think this can be also merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants