Skip to content

Commit

Permalink
Update git submodules
Browse files Browse the repository at this point in the history 
* Update requirements from branch 'master'
  - Update gitdb to 4.0.1, gitdb2 to 4.0.2
    
    The gitdb 4.0.0 release and gitdb2 4.0.1 release has been deleted from
    PyPi and (if I'm reading [1] correctly, which is a big *if*) has been
    replaced with 4.0.1 and 4.0.2 respectively.  [1]:
    
      gitdb v4.0.1 and gitdb2 v4.0.2 should be functionally equivalent to
      gitdb2 v3.0.3 with gitdb v4.0.2 simply installing gitdb >= 4.0.1 and
      with gitdb v4.0.1 requiring smmap rather than smmap2
      (gitpython-developers/smmap#44).
    
    Additionally, it seems that gitdb now also requires smmap>=3.0.1.
    This project is in a similar renaming phase, but 3.0.1 seems to be the
    correct place to be [2]:
    
      v3.0.1 for both packages should be functionally equivalent to smmap2
      v2.0.5, with smmap2 v3.0.1 simply installing smmap >= 3.0.1.
    
    Additionally additionally, there appears to be a problem with
    cross-horizon-npm not obeying new constraints in it's job (possibly
    this is the first time packages horizon cares about have broken?).
    Since this blocks this change from merging, set the job to non-voting
    until we can fix this in a follow-on.
    
    [1] gitpython-developers/gitdb#59
    [2] gitpython-developers/smmap#44
    
    Change-Id: I268fb7e1dc753c82983736572b3df2f152f8cf51
  • Loading branch information
@ianw @openstack-gerrit
ianw authored and openstack-gerrit committed Feb 24, 2020
1 parent 76be0e8 commit c174fbe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion requirements
Submodule requirements updated 2 files
+2 −2 .zuul.d/project.yaml
+6 −6 upper-constraints.txt

1 comment on commit c174fbe

@Harmon758
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, my meaning was that gitdb2 v4.0.2 is now simply a mirror package that has gitdb >= 4.0.1 as a requirement.
Similarly, smmap2 v3.0.1 is now simply a mirror package that has smmap >= 3.0.1 as a requirement.
These mirror packages do nothing except simply install the packages that they mirror.

Otherwise, you're correct regarding gitdb v4.0.0 and gitdb2 v4.0.1.
These were mistakenly released with issues that prompted their deletion and replacement.

Please sign in to comment.