Fix requirements file with editable flag for vcs requirements #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
=======================================
Coverage 89.46% 89.46%
=======================================
Files 14 14
Lines 750 750
=======================================
Hits 671 671
Misses 79 79 |
reedstrm
approved these changes
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release of
pip==10.0.0changed some behavior with our requirements.txt files. In this case the fault is on us and partially on the new release. The requirements lines that point at git repos aren't prefixed with-e, which makes them editable installs and thus reinstallable. The new release is at fault for raising an error rather than saying something to the effect of "the requirement is satisfied and won't upgrade."See pypa/pip#5251