Upgrade typescript to ^4.2.0 and fix lint issues #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiotrKozlowski
commented
Apr 29, 2021
| @@ -0,0 +1,122 @@ | |||
| /// <reference lib="webworker" /> | |||
There was a problem hiding this comment.
content of the previous service worker can be found here: http://rex-web.herokuapp.com/books/service-worker.js
PiotrKozlowski
commented
Apr 29, 2021
| function abs_path { | ||
| (cd "$(dirname '$1')" &>/dev/null && printf "%s/%s" "$PWD" "${1##*/}") | ||
| } | ||
|
|
||
| build=$(abs_path "${BASH_SOURCE%/*}/../build") | ||
| worker="$build"/service-worker.js | ||
|
|
||
| # add cache behaviors for 100% offline load |
There was a problem hiding this comment.
I've moved it to src/service-worker.ts
…fter updating @opesntax/types
|
needs conflicts resolved |
TomWoodward
requested changes
May 12, 2021
| @@ -6,7 +6,7 @@ import { assertNotNull } from '../../utils'; | |||
| describe('setHead hook', () => { | |||
| let hookBody: ActionHookBody<typeof locationChange>; | |||
| const helpers = {} as MiddlewareAPI & AppServices; | |||
| const action = locationChange({location: new URL('http://localhost/'), action: 'PUSH'}); | |||
| const action = locationChange({location: new URL('http://localhost/') as any, action: 'PUSH'}); | |||
There was a problem hiding this comment.
same deal with the location/url situation
src/app/navigation/types.ts
Outdated
| @@ -59,7 +59,7 @@ export interface LocationChange<M = AnyMatch> { | |||
| action: Action; | |||
| } | |||
|
|
|||
| export type AnyRoute = typeof routes[number]; | |||
| export type AnyRoute = NonNullable<typeof routes[number]>; | |||
There was a problem hiding this comment.
this isn't necessary anymore right?
TomWoodward
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for: https://github.com/openstax/unified/issues/1469
For adding support for SW I've followed instructions from this comment: facebook/create-react-app#10032 (comment)