Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tax calculations based on appliedcost #96

Conversation

DNNMonster
Copy link
Collaborator

@DNNMonster DNNMonster commented Apr 15, 2020

I believe the line items are always being taxed based on their full price(totalcost) and this change should reflect any discounts that are applied to the item(appliedcost). I did test this for a single transaction which was accurate but it should be tested more thoroughly with vouchers, dealer discounts in addition to sales. I think the appliedcost is the right element to be using but you'll want to triple check that.

Potential fix for #95.

@DNNMonster
Copy link
Collaborator Author

I think we can potentially drop the isdealer check as well..?? I assume the applied cost will reflect the dealer pricing already but it's a case scenario that has to be tested.

@leedavi
Copy link
Collaborator

leedavi commented Apr 16, 2020

I'm not sure about the appliedtotal, I think this includes shipping and the shipping in France does NOT apply tax on B2C, it's does apply tax on B2B but only certain parcels. However the basic shipping provider does NOT calculate tax on shipping, Which I think is OK for France, but maybe NOT for other countries. Maybe we should have an option on that to turn tax on or off for the provider.

Maybe we should take the time and create some examples, with tax included and tax excluded.

@leedavi
Copy link
Collaborator

leedavi commented Apr 16, 2020

P.S. Thank you very much for looking at this.

@DNNMonster
Copy link
Collaborator Author

Closing this since this is included in another PR in progress which includes shipping tax changes.

@DNNMonster DNNMonster closed this Apr 20, 2020
@DNNMonster DNNMonster deleted the bugfix/dicsounted-price-taxes branch April 28, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants