Merge pull request #8442 from openstreetmap/8441-move-rotate

In move/rotate cancel, check whether graph has changed before popping
openstreetmap · Jun 22, 2021 · 7cb2ff7 · 7cb2ff7
2 parents a0c2c84 + 2651e7d
commit 7cb2ff7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/modules/modes/move.js b/modules/modes/move.js
@@ -113,10 +113,10 @@ export function modeMove(context, entityIDs, baseGraph) {
 
     function cancel() {
         if (baseGraph) {
-            while (context.graph() !== baseGraph) context.pop();
+            while (context.graph() !== baseGraph) context.pop();  // reset to baseGraph
             context.enter(modeBrowse(context));
         } else {
-            context.pop();
+            if (_prevGraph) context.pop();   // remove the move
             context.enter(modeSelect(context, entityIDs));
         }
         stopNudge();

diff --git a/modules/modes/rotate.js b/modules/modes/rotate.js
@@ -119,7 +119,7 @@ export function modeRotate(context, entityIDs) {
 
 
     function cancel() {
-        context.pop();
+        if (_prevGraph) context.pop();   // remove the rotate
         context.enter(modeSelect(context, entityIDs));
     }
 
@@ -130,6 +130,7 @@ export function modeRotate(context, entityIDs) {
 
 
     mode.enter = function() {
+        _prevGraph = null;
         context.features().forceVisible(entityIDs);
 
         behaviors.forEach(context.install);