Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression - 2.30.2 does not work on Firefox 129.0.2 on Linux #10418

Closed
mdykierek opened this issue Aug 21, 2024 · 10 comments
Closed

Regression - 2.30.2 does not work on Firefox 129.0.2 on Linux #10418

mdykierek opened this issue Aug 21, 2024 · 10 comments
Labels
bug A bug - let's fix this!

Comments

@mdykierek
Copy link

URL

https://www.openstreetmap.org/edit#map=13/50.95502/19.37731

How to reproduce the issue?

Empty view. No backgrounds, most options gone.
Console shows error:
Uncaught (in promise) SyntaxError: JSON.parse: unexpected end of data at line 1 column 4365237 of the JSON data
Chrome seems to work.

Screenshot(s) or anything else?

No response

Which deployed environments do you see the issue in?

No response

What version numbers does this issue effect?

No response

Which browsers are you seeing this problem on?

No response

@Dimitar5555
Copy link
Contributor

I'm on Linux Mint using Firefox 129.0.0 and it works fine. Can you downgrade Firefox and see if it works?

image

@mdykierek
Copy link
Author

No it doesn't work on downgraded FF. I am on Ubuntu. FF downloaded from firefox website - tar.bz2. Same error. Worked previously like a charm:
image

@mdykierek
Copy link
Author

Lower the priority. Clearing the cookies and cache fixed the problem.

@tyrasd
Copy link
Member

tyrasd commented Aug 22, 2024

@Firefishy do you have any idea why this could be happening?

Uncaught (in promise) SyntaxError: JSON.parse: unexpected end of data at line 1 column 4365237 of the JSON data

The causing file is almost certainly the imagery.min.json file (currently as asset: https://www.openstreetmap.org/assets/iD/data/imagery.min-cd263495de30d2db72076219027524ea05f895454f7ad0f5279fe382ba396b96.json), which should be slightly bigger file with 4436859 bytes uncompressed. 🤷

@tyrasd tyrasd added bug A bug - let's fix this! bug-cant-reproduce Having trouble reproducing this issue and removed bug-cant-reproduce Having trouble reproducing this issue labels Aug 22, 2024
@convissor
Copy link

Happening on Chrome too (127.0.6533.99 Official Build). Clearing cache (per mdykierek) cleared it up.

@Firefishy
Copy link
Member

Firefishy commented Aug 22, 2024

@Firefishy do you have any idea why this could be happening?

Uncaught (in promise) SyntaxError: JSON.parse: unexpected end of data at line 1 column 4365237 of the JSON data

The causing file is almost certainly the imagery.min.json file (currently as asset: https://www.openstreetmap.org/assets/iD/data/imagery.min-cd263495de30d2db72076219027524ea05f895454f7ad0f5279fe382ba396b96.json), which should be slightly bigger file with 4436859 bytes uncompressed. 🤷

The 3 primary frontend servers are serving identical content:

% curl -k --compressed https://spike-06.openstreetmap.org/assets/iD/data/imagery.min-cd263495de30d2db72076219027524ea05f895454f7ad0f5279fe382ba396b96.json | md5sum
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  962k  100  962k    0     0  8195k      0 --:--:-- --:--:-- --:--:-- 8230k
d57d034af07d49c6558109f8610f18c7  -

% curl -k --compressed https://spike-07.openstreetmap.org/assets/iD/data/imagery.min-cd263495de30d2db72076219027524ea05f895454f7ad0f5279fe382ba396b96.json | md5sum
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  962k  100  962k    0     0  8540k      0 --:--:-- --:--:-- --:--:-- 8597k
d57d034af07d49c6558109f8610f18c7  -

% curl -k --compressed https://spike-08.openstreetmap.org/assets/iD/data/imagery.min-cd263495de30d2db72076219027524ea05f895454f7ad0f5279fe382ba396b96.json | md5sum
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  962k  100  962k    0     0  6787k      0 --:--:-- --:--:-- --:--:-- 6829k
d57d034af07d49c6558109f8610f18c7  -

% curl -k --compressed https://www.openstreetmap.org/assets/iD/data/imagery.min-cd263495de30d2db72076219027524ea05f895454f7ad0f5279fe382ba396b96.json | md5sum
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  956k    0  956k    0     0  2176k      0 --:--:-- --:--:-- --:--:-- 2173k
d57d034af07d49c6558109f8610f18c7  -

The assets look ok to me. Might be broken browser cached versions I guess.

@boothym
Copy link
Contributor

boothym commented Aug 23, 2024

Had this same problem, weirdly enough I opened Chrome developer tools to check the console and then iD worked again - which must be because I had "disable cache" ticked in the network conditions options (not sure if that's default or not).

@Firefishy
Copy link
Member

@tyrasd Worth doing a dummy version bump to change the asset filenames?

tyrasd added a commit to osmlab/openstreetmap-website that referenced this issue Aug 23, 2024
@tyrasd
Copy link
Member

tyrasd commented Aug 23, 2024

something like this @Firefishy? openstreetmap/openstreetmap-website#5112 – though this does not touch the imagery.json file, so it probably will only result in a new asset file name for the js file. If you want I can also create a proper release with updated imagery data set from ELI

@tyrasd
Copy link
Member

tyrasd commented Aug 26, 2024

There haven't been any more reports of this error over the last few days. Hopefully, whatever had caused it has resolved itself. Let's close this and continue monitoring the situation.

@tyrasd tyrasd closed this as completed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

6 participants