Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect positioning of Minnesota Composite Image Service imagery #10430

Closed
knkski opened this issue Aug 23, 2024 · 7 comments
Closed

Incorrect positioning of Minnesota Composite Image Service imagery #10430

knkski opened this issue Aug 23, 2024 · 7 comments
Labels
wontfix-not-iD Issue is with a different project or service

Comments

@knkski
Copy link

knkski commented Aug 23, 2024

URL

https://www.openstreetmap.org/edit#map=21/44.9770183/-93.2263605

How to reproduce the issue?

Go to the above URL and toggle between "Minnesota Composite Image Service" and "Hennepin County Orthoimagery (2024)", see that "Minnesota Composite Image Service" appears offset by approximately a meter

Screenshot(s) or anything else?

Screenshots of the difference:

Screenshot from 2024-08-22 14-03-42

Screenshot from 2024-08-22 14-03-49

I reached out to the contact for the MCIS imagery dataset, who said "My first thought is, has the imagery been converted to the appropriate coordinate system? I believe OSM uses WGS84, and the imagery is in UTM NAD83 Zone 15". That appears to be the issue to me.

The file is too big to link directly to the line, but in data/imagery.json, there's the section with "id": "Minnesota-Composite-Image-Service", that is listed as "projection": "EPSG:3857". This seems incorrect, as it should be https://epsg.io/26915 instead of https://epsg.io/3857, from what I can tell.

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.30.2

Which browsers are you seeing this problem on?

Firefox

@tordans
Copy link
Collaborator

tordans commented Aug 23, 2024

Please check the "editor layer index" repo for the PR that added this imagery an reach out there or open an new issue there. iD does take the images from there.

@knkski
Copy link
Author

knkski commented Aug 23, 2024

@tordans This might be an issue with the import process for iD? Here's the relevant file from that repo:

https://github.com/osmlab/editor-layer-index/blob/gh-pages/sources/north-america/us/mn/MinnesotaCompositeImageService.geojson?short_path=bf2fb59#L807-L810

It lists both EPSG:3857 and EPSG:26915 as available projections, but the file in this repo only lists EPSG:3857. Is that an issue?

@danieldegroot2
Copy link
Contributor

danieldegroot2 commented Aug 23, 2024

Opened a PR as possible quick solution. osmlab/editor-layer-index#2459

Ref osmlab/editor-layer-index#1031

@rbuffat Could you have a look at this, please? It seems this is another issue with generated projections, though maybe it was already fixed for future files.

@tordans
Copy link
Collaborator

tordans commented Aug 23, 2024

@tordans
Copy link
Collaborator

tordans commented Aug 23, 2024

@knkski I am wondering why you think this is an projection issue? Comparing Bing vs. the other options, it looks to me that all the other options show the buildings in the same position but Bing is off. It is not uncommon that different image layers are off by a bit which is why you can adjust the image layer position to fit the commonly used mapping in that area.

@danieldegroot2
Copy link
Contributor

The author seems to have been confused by OSM using EPSG:3857 instead of the more local NAD83. (not a preference of the editor itself), or it is a typo they mixed up the projections.

@tordans First layer shown on screenshots is Hennepin County, second is Minnesota Composite. Objects line up with both Bing and Hennepin but not with Minnesota Composite.

@tyrasd tyrasd added the waitfor-upstream Waiting for something in an upstream project label Aug 23, 2024
@tyrasd
Copy link
Member

tyrasd commented Aug 23, 2024

It lists both EPSG:3857 and EPSG:26915 as available projections, but the file in this repo only lists EPSG:3857. Is that an issue?

No, that's fine: as iD can only consume EPSG:3857 (and its aliases) or EPSG:4326 (#4858) sources, all other projections are not included in the bundled file for iD.

@tyrasd tyrasd closed this as completed Aug 23, 2024
@tyrasd tyrasd added wontfix-not-iD Issue is with a different project or service and removed waitfor-upstream Waiting for something in an upstream project labels Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix-not-iD Issue is with a different project or service
Projects
None yet
Development

No branches or pull requests

4 participants