Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign, fixup markers #172

Closed
tmcw opened this issue Dec 3, 2012 · 10 comments
Closed

Redesign, fixup markers #172

tmcw opened this issue Dec 3, 2012 · 10 comments

Comments

@tmcw
Copy link
Contributor

tmcw commented Dec 3, 2012

So lots of directions here:

  • SVG markers with maki
  • Same markers, just prettier / sprited / different background
  • Or something else entirely.

Refs:

drawMarkers: https://github.com/systemed/iD/blob/master/js/id/renderer/map.js#L185

@samanpwbb
Copy link
Member

In order to replace the current marker set, we'd need an alternative for every icon here: https://github.com/systemed/iD/tree/master/icons

Maki is already well on its way to covering all these icons, but I would need to make a few dozen additional symbols. Here's what needs to be added to Maki in order to be able to fully replace the current icons set:

POI icons

  • alpinehut
  • atm
  • bandb
  • but station (separate from bus stop).
  • carshare
  • caravanpark
  • chalet
  • communications
  • danger
  • florist ( Maki uses a flower for garden, so that conflict needs to be sorted out)
  • food_drinkingtap
  • guesthouse
  • halt
  • hostel
  • information
  • lighthouse
  • parking ( 3 types: cycle, private, normal)
  • peak
  • place (?)
  • cave
  • post office box (separate from post office)
  • power_pole
  • power_tower_3x3
  • power_tower_5x5
  • power_tower
  • power_wind
  • recycle
  • recycling (what's the difference between this and 'recycle'?)
  • rental_bicycle
  • shop_bakery
  • shop_butcher
  • shop_clothes
  • shop_diy
  • shop_hairdresser
  • shop_car_repair
  • sikh
  • sosphone
  • spring
  • station_disused
  • station_small
  • station
  • telephone
  • toilets
  • tourist_archaeological
  • tower_water
  • tower
  • traffic_light
  • transport_ford
  • transport_slipway
  • unknown
  • view_point
  • walking
  • windmill

abnormal icons

  • allotments
  • arrow_back
  • arrow
  • bollard
  • cablecar
  • chairlift
  • cliff1
  • cliff2
  • lock-gate
  • level_crossing
  • level_crossing2
  • liftgate
  • gate
  • gate2
  • halt
  • mini_round
  • power_line
  • turning circles (?)

Repeating patterns

  • beach
  • danger
  • glacier
  • glacier2
  • forest
  • grave_yard_generic
  • grave_yard
  • landfill
  • marsh
  • military_red_hz2
  • military_red
  • millitary_restraint
  • mud
  • nature_reserve
  • nature_reserve2
  • nature_reserve2T
  • nature_reserve5
  • nature_reserve6
  • nature_reserveT
  • orchard
  • quarry
  • scrub
  • vineyard
  • zoo

Shields
All the shields (?)

Maybe

  • department store (Maki has a general shop icon, might do the trick)
  • memorial ( Maki has 'monument', so this should be covered)

This should probably be sprited, but an alternative would be to render the SVG's in browser. Would this be hard on performance? The advantages are that markers would be easier to style and scale.

@tmcw do you know why there are so many duplicate icons? there is airport.png and then airport.p.16.png for example, but they're both identical. Also, do you know if all of the icons are being used?

@ghost ghost assigned samanpwbb Dec 4, 2012
@lxbarth
Copy link
Contributor

lxbarth commented Dec 13, 2012

@samanpwbb - how long would it take you to make all the missing icons?

@samanpwbb
Copy link
Member

@lxbarth two weeks.

@jfirebaugh
Copy link
Member

We're now using maki icons, matching the presets. Still needs some design attention though. I couldn't quite get the icon centered, and I'd like to see what a reverse teardrop shape looks like.

@jfirebaugh
Copy link
Member

Here's how they look with a traditional marker outline:

image

I think this contrast better with how we're now rendering tagged vertices.

image

(Those traffic signals need a maki icon.)

@talllguy
Copy link

@samanpwbb The icons link is now dead. Is there a new one?

@samanpwbb
Copy link
Member

@talllguy not sure- that was a repo maintained by @systemed

I wasn't paying attention :) Let me look.

@jfirebaugh
Copy link
Member

Current equivalent link would be something like https://github.com/openstreetmap/iD/tree/3744ca602d5329426f5516189c25aae46a4341e9/icons

@samanpwbb
Copy link
Member

@talllguy what are you looking for? Maki has far surpassed where it was when we had this conversation.

@talllguy
Copy link

Thanks gentleman! I was actually interested if there was a military related icon, for my #2177 issue, so I was looking for an icon / maki to go along with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants