-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign, fixup markers #172
Comments
In order to replace the current marker set, we'd need an alternative for every icon here: https://github.com/systemed/iD/tree/master/icons Maki is already well on its way to covering all these icons, but I would need to make a few dozen additional symbols. Here's what needs to be added to Maki in order to be able to fully replace the current icons set: POI icons
abnormal icons
Repeating patterns
Shields Maybe
This should probably be sprited, but an alternative would be to render the SVG's in browser. Would this be hard on performance? The advantages are that markers would be easier to style and scale. @tmcw do you know why there are so many duplicate icons? there is |
@samanpwbb - how long would it take you to make all the missing icons? |
@lxbarth two weeks. |
We're now using maki icons, matching the presets. Still needs some design attention though. I couldn't quite get the icon centered, and I'd like to see what a reverse teardrop shape looks like. |
@samanpwbb The icons link is now dead. Is there a new one? |
Current equivalent link would be something like https://github.com/openstreetmap/iD/tree/3744ca602d5329426f5516189c25aae46a4341e9/icons |
@talllguy what are you looking for? Maki has far surpassed where it was when we had this conversation. |
Thanks gentleman! I was actually interested if there was a military related icon, for my #2177 issue, so I was looking for an icon / maki to go along with that. |
So lots of directions here:
Refs:
drawMarkers: https://github.com/systemed/iD/blob/master/js/id/renderer/map.js#L185
The text was updated successfully, but these errors were encountered: