-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further country specific customization of address fields #2254
Comments
That’s a good point. I considered translating the placeholders more literally, but doing so would’ve persisted the confusion that I described in #2252. One consequence of the language being closely associated with one country is that foreign administrative structures are typically mapped to the same terminology used in Vietnam. But this proposal would be much more useful for English, which tends to use country-specific terminology. Note that placeholders would still have to be defined outside of address-formats.json, so that they can be localized in Transifex. |
Country-specific field names would also be useful for turning “Postcode” into the more recognizable “ZIP Code” for U.S. addresses. |
(Cross-posting from #3639 (comment), since that’s a closed PR with little visibility.) The Japanese address format added in #3712 is a perfect example of why we need the ability to translate the placeholders on a per-country basis. In Vietnamese, |
(Cross-posting my response 😆 ) Oh yeah I should have updated this ticket, but after looking at #3712, I do understand why this is important. |
(Also a cross-post) The whole Japanese address system is complicated. To show this I've made this graph:
It has the common English translations of all fields. As you see the That's why the country-specific placeholders are needed in Japan. |
I think this was done in #3643 |
In relation to #2252, using translation to incorporate country-specific placeholder to provide tagging info may work in the case when a language is closely tied to a single country, but not possible in general. Now that we have a vehicle to tailor the address presets per country, I think it would be useful to generalize the
address-formats.json
file a bit to allow further country specific customization - such as:Something like (just for example):
The text was updated successfully, but these errors were encountered: