Further address customization #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… address-customization
bhousel
reviewed
Jan 16, 2017
| .attr('class', function (d) { return 'addr-' + d.id; }) | ||
| .style('width', function (d) { return d.width * 100 + '%'; }); | ||
|
|
||
| // Update | ||
| var addrTags = [ | ||
| // setup dropdowns for common address tags | ||
| if (typeof addressFormat.dropdowns !== 'undefined') { addrTags = addressFormat.dropdowns; } |
There was a problem hiding this comment.
Hey @natsuyasumi I'd like to get this code merged this week, so I'm taking a look through it now..
Is the reason for addressFormat.dropdowns so that you can turn block_number ("Building No.") and housenumber ("Lot No.") into dropdown fields?
There was a problem hiding this comment.
I've created the addressFormat.dropdowns for simplicty, so that you don't have to add this fields-that-should-have-dropdowns in address,js. The housenumber field doesn't have dropdown.
There was a problem hiding this comment.
@natsuyasumi Ok, makes sense, thanks!
|
Just merged this.. thanks @natsuyasumi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR #3639.
I wanted to create Japanese address scheme, but the generic placeholders doesn't fit with the Japanese tags (especially city, suburb, quarter and neighbourhood). Additionally there are up to 3 numeric address parts, so the
123housenumber placeholder will mislead users.The Vietnamese-specific placeholders are imported from (PR #2252)[https://github.com//pull/2252]