Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connected entities are disconnected after copy and paste #2584

Closed
pmailkeey opened this issue Apr 10, 2015 · 7 comments
Closed

Connected entities are disconnected after copy and paste #2584

pmailkeey opened this issue Apr 10, 2015 · 7 comments
Labels
bug A bug - let's fix this!

Comments

@pmailkeey
Copy link

Copying and pasting - if you select several joined items (sharing points) as a group, copy and paste them elsewhere, the pasted items are no longer connected and can be moved individually. I guess this will create an error of more than one node in the same place unless things are reconnected.

@bhousel bhousel changed the title iD f8bd67c beta Overlapping points and copy/paste Apr 12, 2015
@bhousel
Copy link
Member

bhousel commented Apr 12, 2015

Yeah I can see how this would be an issue. I'm thinking if a user copies a bunch of stacked up nodes with uninteresting tags, we should only paste a single node.

@pmailkeey
Copy link
Author

On 12 April 2015 at 04:26, Bryan Housel notifications@github.com wrote:

Yeah I can see how this would be an issue. I'm thinking if a user copies a
bunch of stacked up nodes with uninteresting tags, we should only paste a
single node.

Not keen on 'data loss'. Whatever's copied should be pasted as is - if
objects are joined at nodes then they should paste joined up too. That's
the issue.

@bhousel
Copy link
Member

bhousel commented Apr 14, 2015

Oh, I think I misunderstood...
You are saying if a user selects some points that are connected and copy/pastes them, they should stay connected as a way?

Copying this:
screenshot 2015-04-14 14 00 49

Should result in this:
screenshot 2015-04-14 14 02 48

Not this:
screenshot 2015-04-14 14 03 06

Is that right?

@bhousel bhousel changed the title Overlapping points and copy/paste Copy/Paste Segments Apr 14, 2015
@pmailkeey
Copy link
Author

Good job you didn't change the issue number as well ;)

Yes, that's right and this (2 squares)

image

should paste like this:

image

and not like this:

image

i.e. shared nodes of the two squares remain shared, not as 2 separate squares with nodes in the same place but not connected.

@jfirebaugh
Copy link
Member

This is out of scope for iD.

@slhh
Copy link
Contributor

slhh commented Feb 5, 2016

@jfirebaugh I'd agree on copying of segments beind out of scope. It is rarely required and other methods to acceive the result exist.
The original was describing a copy and paste bug which still exists and seem to be quite valid. The comments seem to be a series of misunderstandings. "Copy segments" is only what @bhousel has made out of the original issue due to misunderstanding.

@jfirebaugh
Copy link
Member

Ah, I see. Thanks for clarifying.

@jfirebaugh jfirebaugh reopened this Feb 5, 2016
@jfirebaugh jfirebaugh changed the title Copy/Paste Segments Connected entities are disconnected after copy and paste Feb 5, 2016
@jfirebaugh jfirebaugh added bug A bug - let's fix this! and removed enhancement labels Feb 5, 2016
jfirebaugh added a commit that referenced this issue Feb 8, 2016
jfirebaugh added a commit that referenced this issue Feb 8, 2016
jfirebaugh added a commit that referenced this issue Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

4 participants