Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With multiple features selected, indicate which one is mouse-hovered in the sidebar multiselect list #2949

Closed
slhh opened this issue Jan 31, 2016 · 10 comments · Fixed by #7628
Labels
help wanted For intermediate contributors, requires investigation or knowledge of iD code usability An issue with ease-of-use or design
Milestone

Comments

@slhh
Copy link
Contributor

slhh commented Jan 31, 2016

Edit: The remaining task is highlighting the list item when hovering the selected feature on the map, which is discussed and agreed on starting here: #2949 (comment)
Original issue:

Identification of items in the multiselect list should be improved:

When the mouse is over an item of the list, selection halos of all other selected elements should be disabled temporarily.

This will likely require similar software infrastructure as #2946 , and is a prerequisite for some further potential enhancements of iD.

@bhousel
Copy link
Member

bhousel commented Feb 1, 2016

I'm not removing the halo from the other selected items. They are still selected and the user shouldn't forget about that just because they happen to put their mouse over that selection list.

But I agree that:

  • when mousing over a list item, that feature should get a hover style (maybe it does already)
  • the hover style should be more distinguishable from the select style with consideration for colorblind users (I think it may only get a slight opacity bump)
  • breathe behavior needs to be aware of hover style if it is mucking with opacity

@slhh
Copy link
Contributor Author

slhh commented Feb 3, 2016

I'm not removing the halo from the other selected items.

I believe the user wants to go through the list quite fast searching for an item. Anything delaying the visisual detection of the hovered feature seems to be bad.

They are still selected and the user shouldn't forget about that just because they happen to put their mouse over that selection list.
I would disagree in this specific case. While the mouse is over the buttton the users can't do anything harmful with the mouse. The only hamful thing they can do is using some shortcut keys, but they can't really work on the map for any significant time period without moving the mouse away from the hovered item; therefore they don't really have time to forget.

If the users were able to fill in the inspector with the keybord during hovering the item, I would agree; but the inspector is unavailable while the multiselect list is open.

In addition multiple items being selected is still visible, because the multiselect list is shown.

If you still want to protect something, you can consider disabling shortcut keys which are changing map data according to the hidden selection; but I think the risk is very low anyway.

@slhh
Copy link
Contributor Author

slhh commented Feb 3, 2016

In addition to the hover function, which has been discussed above, a reverse hover function would be useful. If the mouse is over one or more selected items on the map, the respective item of the multiselect list should be highlighted. The list should be automatically scrolled to to show this item if required.
Example usecase: lasso selection and need to remove a few nodes from the selection subsequently, which can be identified on the map, but not in the list. Currently, the user has to hover every item in the potentially long list sequentially to find the nodes to be removed.

@bhousel bhousel added considering Not Actionable - still considering if this is something we want and removed enhancement labels Nov 1, 2016
@slhh
Copy link
Contributor Author

slhh commented Oct 19, 2018

@quincylvania, @bhousel,
How do you think about my last comment here?

Everything else was done in #5402, thanks @quincylvania.

@quincylvania
Copy link
Collaborator

@slhh Reverse hover-highlighting does sound useful! I'd recommend creating a new issue for it and closing this issue since the original task was completed. I think it's more likely that someone will decide to work on an issue if it is clearly defined with a small scope (though this isn't always possible.)

@bhousel
Copy link
Member

bhousel commented Oct 20, 2018

If the mouse is over one or more selected items on the map, the respective item of the multiselect list should be highlighted. The list should be automatically scrolled to to show this item if required.

Sounds ok to me 👍

@slhh
Copy link
Contributor Author

slhh commented Oct 20, 2018

I'd recommend creating a new issue for it and closing this issue since the original task was completed.

@bhousel, feel free to request this, but I think we don't need to do so in this special case. The title does still fit and I have edited the original post to make clear what is remaining.

Otherwise, please update the label. We seem to have consent, and the considering label might prevent contributions.

@bhousel
Copy link
Member

bhousel commented Oct 21, 2018

oh yeah, we don't really need a new issue. I'll just retitle it..

@bhousel bhousel changed the title Multiselect list: Improve identification of items With multiple features selected, indicate which one is mouse-hovered in the sidebar multiselect list Oct 21, 2018
@bhousel
Copy link
Member

bhousel commented Oct 21, 2018

Just to restate the issue with a gif - it's this:
We currently support hovering on list items to highlight map features. We should also support hovering on map items to highlight list features.
multi select

@bhousel bhousel added usability An issue with ease-of-use or design help wanted For intermediate contributors, requires investigation or knowledge of iD code and removed considering Not Actionable - still considering if this is something we want labels Oct 21, 2018
@TAQ2
Copy link
Contributor

TAQ2 commented Oct 26, 2019

Hi I'm a new contributer and would like to look at this. Please could someone give me a hint as to where the code for this is, its a new and large codebase so a few comments from someone will save me a few hours of digging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted For intermediate contributors, requires investigation or knowledge of iD code usability An issue with ease-of-use or design
Projects
None yet
5 participants