-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With multiple features selected, indicate which one is mouse-hovered in the sidebar multiselect list #2949
Comments
I'm not removing the halo from the other selected items. They are still selected and the user shouldn't forget about that just because they happen to put their mouse over that selection list. But I agree that:
|
I believe the user wants to go through the list quite fast searching for an item. Anything delaying the visisual detection of the hovered feature seems to be bad.
If the users were able to fill in the inspector with the keybord during hovering the item, I would agree; but the inspector is unavailable while the multiselect list is open. In addition multiple items being selected is still visible, because the multiselect list is shown. If you still want to protect something, you can consider disabling shortcut keys which are changing map data according to the hidden selection; but I think the risk is very low anyway. |
In addition to the hover function, which has been discussed above, a reverse hover function would be useful. If the mouse is over one or more selected items on the map, the respective item of the multiselect list should be highlighted. The list should be automatically scrolled to to show this item if required. |
@quincylvania, @bhousel, Everything else was done in #5402, thanks @quincylvania. |
@slhh Reverse hover-highlighting does sound useful! I'd recommend creating a new issue for it and closing this issue since the original task was completed. I think it's more likely that someone will decide to work on an issue if it is clearly defined with a small scope (though this isn't always possible.) |
Sounds ok to me 👍 |
@bhousel, feel free to request this, but I think we don't need to do so in this special case. The title does still fit and I have edited the original post to make clear what is remaining. Otherwise, please update the label. We seem to have consent, and the considering label might prevent contributions. |
oh yeah, we don't really need a new issue. I'll just retitle it.. |
Hi I'm a new contributer and would like to look at this. Please could someone give me a hint as to where the code for this is, its a new and large codebase so a few comments from someone will save me a few hours of digging |
Edit: The remaining task is highlighting the list item when hovering the selected feature on the map, which is discussed and agreed on starting here: #2949 (comment)
Original issue:
Identification of items in the multiselect list should be improved:
When the mouse is over an item of the list, selection halos of all other selected elements should be disabled temporarily.
This will likely require similar software infrastructure as #2946 , and is a prerequisite for some further potential enhancements of iD.
The text was updated successfully, but these errors were encountered: