-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for lane and turn lane tagging #387
Comments
Do any existing map styles or editors do this? |
The approved lane tagging is rather new so support is limited. There is a map style for JOSM in two versions that supports the tagging see http://wiki.openstreetmap.org/wiki/Josm/styles/lane_features Currently there is some support in OsmAnd for navigation and I suspect others will follow now that there is an established method of tagging, It is likely for lane tagging to be very popular down the road once it actually has an effect, so while I would classify supporting it for a first release as not necessary it is something that will probably have to be done down the road. |
Here is a link to the proposal I submitted for my google summer of code application. |
@kepta Thanks for sharing your proposal, I will comment later. |
@kepta
I don't see how splitting whithin the lane editor could work, because it needs to be made at the correct geoposition. I think the radial menu split operation is sufficient anyway. What could be implemented in the lane editor is a longitudinal split due to a physical separation between lanes. It is a useful operation, but handling affected relations doesn't seem to be easy. Therefore, this has a low priority. Instead of drawing allways rectangles the lanes should be drawn like following example: The information defined using the keys It is important to support the witdth:lanes and placement keys including their :start and :end variants because they are not only required for lane rendering but also are very useful to define connectivity. |
Users should not be required to use the lanes tagging syntax, therefore a lanes editor should not support a subset only of applicable keys. Therefore, I suggest a more generalized approch: |
The lane editor should not only cover keys with The same applies with forward replaced by backward direction and the arrow at the left side of the lanes drawing. |
The lane editor needs to care about right-hand or left-hand traffic, based on tagging of the highway and also the country-specific default. This is not only relevant for the graphics, but also for matching the value parts of |
These are in the direction of the OSM way and I'm having a hard time coming up with a situation where this matters except for display. Could you explain? Unfortunately, the wiki page is very short on examples of lane tagging for non-oneway roads. |
Example with two forward and two backward lanes:
|
Are you sure? The proposal says |
In the case of two driving directions using the pure |
@kepta |
Hey @slhh, yes I am aware of that.
I am really sorry I forgot to mention it in my proposal. |
@kepta, how do you intend to address that issue? What bhousel did point out seems to be only a part of the problem.
Personally, I would prefer to deprecate |
@kepta, @bhousel I see the following main applications for the lane specific data, but these potential applications are prevented by missing data in most regions currently:
The lanes editor should encourage users to provide the required information to enable these applications. In addition to all keys mentioned above, their |
@kepta, @bhousel
|
Just for your information: OsmAnd uses turn:lane tagging for its navigation. |
Nice! Example of ways with both forward and backwards would be interesting, too. |
@HolgerJeromin |
I thought about adding it to the table in the sidebar. But in the map is perfect. |
When I first started editing osm with iD, the bike lane editor had the right and left side editor, which was confusing at first. I glanced at the selected way, saw the small arrows, and mapped according to which side was left and right. I don't think that this should be the number one concern |
One simple solution would be rendering the cardinal directions in the editor as subtle letters on the sides. This would let people know that there is a directionality to the editor. |
Another idea I have is render the lane display based on a .json rendering file that can be different depending on which country the lanes are being edited in. Most of Europe does not have a double yellow stripe in the center of the road, but rather a double white stripe. |
Of course, a popover with the same information as my sketch would likely be better, since even less space is used. |
@BjornRasmussen When the sidebar is open, using a popover requires even more space. In addition, a popover needs a control to be opened. |
You need to differentiate pure forward/backward indications and "through" turn indications. |
Hi! I am very happy to see new energy in this thread. However, I don't know if I still know what the goal of this thread is. I write this, because I see a real issue with trying to solve all lane related tagging in one place. Which will IMO become a huge mess of complexity (like this thread show already, IMO). And I am really not sure if its even possible to build a UI for all this. In case we try to find a UI that "consolidate(s) all of the "stuff tagged on a street" into a single place" (like bhousel put it and quincylvania visualized it), I see two mayor issues: 1. Separate lanes vs. "everything on one lane". Most mockups above assume IMO, that there is one way which holds all the tags. Eg #387 (comment) and #387 (comment). The advantage is, that the UI looks very good and easy to use. I also feel like the community is slowly pushing towards tagging separate was for separate traffic sources. Like https://www.youtube.com/watch?v=DHecYP_b3os (a good talk!). This development is IMO accelerated by the need for more descriptive tagging (like bike-lane-width and -smoothness, …) on ways, which would otherwise cause the main-way to be segmented into a hundred peaces, making it impossible to maintain (think: parking tagging on a street + turn lanes + bike-lane-width on one way). 2. Not just lane tags, but all the sub-tags as well The other issue is, that having a UI that handles the lanes is one thing. But the same UI should also allow to add all the descriptive sub-tags as well. I see #387 (comment) started adding a few of those. But there a quite a few more. And they are different per "lane" (eg. parking-sub-tags vs. driving-sub-tags). This will make the UI very complex. We could just leave this part out, but then the new UI will be a lot of work and break later once we try to add "tagging-depth" to it. Two approachesOne UI for all Lets assume we find a UI that can deal with the separate lane-issue (1) above and also handle "sub-tags" (2). Which might be possible given enough dev-power! I feel like the discussion here is not really clear about what we want to add to this UI. What are the features we need to add to this UI? IMO https://streetmix.net/-/773938 is a good start:
If this thread continues this road, I suggest we first collect the cases we want to handle with the UI. The list above could be a starting point. Separate UIs On the other hand, we could just start by adding a great UI per use-case.
Maybe we could even think about how to push the mapping forward in the direction of "separate lanes per means of transport". Eg by adding a "split the sidewalk (or cycle lane) tags from this way into a separate way"-feature. |
@BjornRasmussen said:
Yep, I was thinking something like this as well. Either below the lanes, or as I said in my one comment, "You would click on a lane to open an editing popover." This could also apply to dividers if the OSM tagging is that far developed. @tordans said:
I'm all for this! I vastly prefer separate sidewalks and even bike lanes, but if people keep tagging this stuff on roads then I do think it makes sense to show them in the lane layout.
We can start with the basic lane info (access, turns) and see what makes sense after that. The point is to make lane-tagging possible and easy, not to do everything 😅 |
I am glad to hear that. That would mean, we can now find the best solution to handle the following tags, right?
and
Source: https://wiki.openstreetmap.org/wiki/Key:turn#Example_for_a_road_with_both_directions But also destination tags? - https://wiki.openstreetmap.org/wiki/Key:destination So we need to be able to …
If so, the first question for the UI is IMO:
|
I would prefer both, with the option to turn rendering of lanes situated next to the wireframe option in |
I think that it would be too difficult to work this into the interface, but maybe would fit somewhere in the pop-up. |
Edit - after reading all the comments regarding this issue, it has occurred to me that a lot of commenters are arriving at the same sort of concerns regarding the challenges behind creating an interface for solving this issue, what I typed-up below is essentially a rephrasing of ideas that commenters have already come up with (I had yet to actually read all of the previous comments regarding this issue at the time when I wrote it, it looks like we are all more or less on the same page) I was designating 'turn:lane' tags for 'ways' using the current iD editor, it requires a certain amount of focus to get right, otherwise the user may confuse the direction of the 'way' with the intended direction of the 'tag' in conjunction with the road markings seen in the background layer (as the forward heading direction of a 'way' is defined by the direction in which it is drawn, there have been times that I have mistakenly assumed that the forward heading direction of the way is the same as the side of the road in which traffic flows, which has led me to designate tags accordingly only to realize later that the heading of the way is in reverse, that coupled with a background layer that is always facing upright can make designating turn:lane tags a rather focus intensive process) in this regard, a function in the iD editor that came to mind, that I thought was rather intuitive is the 'turn restriction' box would it not be possible to present the 'turn:lane', 'parking:lane', 'road markings, etc' tags for each respective lane with similar presentation and functionality of the 'turn restriction' box? if the angle for each symbol of each respective lane tag were facing the same orientation as the 'way' itself (as seen in the turn restriction box), that would make it much easier for the user to orient themselves with the respective tags of each lane in conjunction to the orientation of the 'background layer' https://i.imgur.com/PJxpPip.jpg as the orientation in which a 'way' can be either 'forward' or 'backward' and angled toward any direction, having a box with all the lane details presented facing upwards (as shown in the image below), the user may end up feeling as disoriented as with the current setup available in the iD editor https://i.imgur.com/vhNHga0.png imagine designating 'turn restrictions' if the orientation of the 'way' in the turn restriction box were facing upright rather than at the orientation of the way itself, things could get rather confusing without a certain amount of focus just a thought |
Removing the WIP label usually means, the feature is complete. Can I get my hands on a working testbed? |
@hungerburg Removal of WIP just signifies work is no longer actively in progress. There'd be a lot more buzz on this issue if the feature was complete 😄 |
Is the abandoned work of Quincy's open source? Recently someone did some lane tagging in the area of my local_knowledge with iD and I think, they mostly did that manually, at least not all the stuff passes validation, so I think that it be worthwhile to continue that work, the screenshots looking very nice indeed. |
bumping this issue because there's multiple designs and working prototypes and I really want to see this integrated into iD. JOSM's turn lane plugin sucks |
@HexCodeFFF, I think that's a trend with iD development in general. I wouldn't get my hopes up. I completely gave up on any iD contributions a few weeks after posting this thread: #9500 |
Damn. Sucks cause iD is, imo, much cleaner and easier to use than JOSM but there's no plugins and slow development. |
Putting in a plug for a-b-street/osm2streets#216 -- we have a web app for visual lane tagging started. Could use help with getting OAuth to work, and with design/implementation for a nicer UI to edit (rather than raw tags). Happy to adapt/use one of the designs from earlier in this thread -- better to get something going and iterate quickly. |
The road style should reflect the number and type of lanes added.
Further a smplified method of tagging lanes should be available.
See http://wiki.openstreetmap.org/wiki/Key:lanes and http://wiki.openstreetmap.org/wiki/Key:turn
The text was updated successfully, but these errors were encountered: