Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add religion, denomination fields to school preset #4722

Closed
1ec5 opened this issue Jan 21, 2018 · 5 comments
Closed

Add religion, denomination fields to school preset #4722

1ec5 opened this issue Jan 21, 2018 · 5 comments
Labels
preset An issue with an OpenStreetMap preset or tag

Comments

@1ec5
Copy link
Collaborator

1ec5 commented Jan 21, 2018

In some countries, it’s common for a school to be affiliated with a particular religious denomination. The amenity=school preset should have a fields for the religion and denomination tags, just like the amenity=place_of_worship preset. According to taginfo, these tags are only used in combination with amenity=school about 0.45% and 0.32% of the time, respectively; if that isn’t enough to justify showing the fields by default, then at least they could be optional fields.

These fields were previously suggested in #1663. Apparently this combination was uncommon back in 2013, though I’ve been using it since 2008. 🤷‍♂️
@1ec5 1ec5 added the preset An issue with an OpenStreetMap preset or tag label Jan 21, 2018
@bhousel
Copy link
Member

bhousel commented Jan 22, 2018

sgtm, I added this 👍

jgravois added a commit to jgravois/iD that referenced this issue Jan 23, 2018
@jgravois
Merge remote-tracking branch 'upstream/master' into bump-v2.6.0
4b2c508 
* upstream/master: (206 commits)
  `barrier=kerb` can also be mapped as a line
  made desired tweaks to kerb.json
  Restore area fill from local storage including wireframe
  Added smoking area preset
  changed "water tank" to "emergency water tank"
  chore(package): update rollup to version 0.55.0
  Corrected discrepancies between upstream and local files
  changed icon to "water"
  Use dark halo around text, switch to svgPath to get viewport clipping
  `highway=motorway_link` no longer implies `oneway=yes` (closes openstreetmap#4727)
  Restore user disabled features from local storage
  Draw covered/underground lines beneath areas (closes openstreetmap#4718)
  Add religion, denomination fields to school preset (closes openstreetmap#4722)
  Add religion, denomination fields to religious landuse preset (closes openstreetmap#4721)
  added a water tank preset
  Restore latest imagery used from local storage
  Fix typo
  v2.6.0
  npm run translations
  npm run imagery
  ...
@bhousel bhousel mentioned this issue Feb 1, 2018
Merged
@naoliv
Copy link

naoliv commented Feb 18, 2018 •
edited
Loading

Is it possible to restrict this to some countries only? (or maybe remove from some specific countries)
While there are some schools affiliated/related with a religion or religious organization in Brazil, they are the minority, for example.

@willemarcel
Copy link
Contributor

Although in some countries the number of schools affiliated with a religion is really relevant, I think the default fields of a preset should be the ones that are more generic and apply for almost all cases. In my opinion, denomination and religion are not a must have field, so I would suggest it to be optional.

@1ec5
Copy link
Collaborator Author

1ec5 commented Feb 18, 2018

Sure, I originally proposed that they be optional fields up above. I think that’s reasonable because government or unaffiliated schools are common enough even in countries where religiously affiliated schools are the norm.

@1ec5 1ec5 mentioned this issue Mar 10, 2018
Closed
@1ec5
Copy link
Collaborator Author

1ec5 commented Mar 10, 2018

In my opinion, denomination and religion are not a must have field, so I would suggest it to be optional.

I agree with @willemarcel that denomination and religion should be hidden by default for the school preset. Unfortunately, I just realized iD doesn’t support optional fields for specific presets, so I opened #4871 to get that feature added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bhousel @willemarcel @naoliv @1ec5