Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing some fields for railway preset #4919

Closed
abdeldjalil09 opened this issue Mar 20, 2018 · 14 comments
Closed

missing some fields for railway preset #4919

abdeldjalil09 opened this issue Mar 20, 2018 · 14 comments
Labels
preset An issue with an OpenStreetMap preset or tag

Comments

@abdeldjalil09
Copy link
Contributor

abdeldjalil09 commented Mar 20, 2018

https://wiki.openstreetmap.org/wiki/Tag:railway%3Drail
usage=#
frequency=# (with electrified=contact_line/rail)
voltage=# (with electrified=contact_line/rail)

@boothym
Copy link
Contributor

boothym commented Mar 20, 2018

Also frequency and voltage fields should appear when selecting electrified=contact_line/rail in the dropdown

@abdeldjalil09 abdeldjalil09 changed the title "usage=" field for railway presets missing some fields for railway preset Mar 23, 2018
@abdeldjalil09
Copy link
Contributor Author

abdeldjalil09 commented Mar 23, 2018

Also frequency and voltage fields should appear when selecting electrified=contact_line/rail in the dropdown

Thanks for more informations

@bhousel
Copy link
Member

bhousel commented Mar 23, 2018

Also frequency and voltage fields should appear when selecting electrified=contact_line/rail in the dropdown

We don't currently support having fields appear and disappear depending on values entered

(Except for certain cases like the structure bridge=*/tunnel=*/etc field, because those are popular and worth adding the custom code to do it).

@bhousel bhousel added the preset An issue with an OpenStreetMap preset or tag label Mar 23, 2018
@boothym
Copy link
Contributor

boothym commented Mar 23, 2018

Is there a lot of work involved in adding the custom code for electrification?

@bhousel
Copy link
Member

bhousel commented Mar 23, 2018

Is there a lot of work involved in adding the custom code for electrification?

It would not be a lot of work to have the fields show up all the time and I think it's ok to expect the user to know whether to use them.

@quincylvania
Copy link
Collaborator

Also frequency and voltage fields should appear when selecting electrified=contact_line/rail in the dropdown

This is now possible with #5583. I did it in 2804ef3. Enjoy!

@boothym
Copy link
Contributor

boothym commented Jan 17, 2019

Thanks - is it live in the preview to try?

@quincylvania
Copy link
Collaborator

Yep! Since Frequency and Voltage aren't high priority I moved them to the "Add fields:" section. So first pick and Electrification value and then use the dropdown. If there are pre-existing values then the fields will appear regardless of the electrified value.

http://preview.ideditor.com/master/#background=Bing&disable_features=boundaries&id=w43344423&map=17.73/39.95727/-75.18366

@boothym
Copy link
Contributor

boothym commented Jan 17, 2019

Hmm that's a bit of a regression to me. If someone sets a railway to electrified=contact_line or rail then they should immediately be shown the frequency and voltage fields below the electrified field (just like if you select "tunnel" you get more options).

Though if were are considering low priority thing then how about removing the ford option from the structure field! :)

@bhousel
Copy link
Member

bhousel commented Jan 17, 2019

Though if were are considering low priority thing then how about removing the ford option from the structure field! :)

Just because you don't use it doesn't mean we need to make someone else unhappy by removing it.

@quincylvania
Copy link
Collaborator

Hmm that's a bit of a regression to me. If someone sets a railway to electrified=contact_line or rail then they should immediately be shown the frequency and voltage fields below the electrified field (just like if you select "tunnel" you get more options).

It is an extra step to add these fields but I hope we can give the change a chance. I'm imaging a casual mapper identifying overhead contact lines in imagery and setting that Electrification value. Then two new fields immediately pop up that require research or domain-specific knowledge? Not the best experience.

@slhh
Copy link
Contributor

slhh commented Jan 18, 2019

I'm imaging a casual mapper identifying overhead contact lines in imagery and setting that Electrification value. Then two new fields immediately pop up that require research or domain-specific knowledge?

A mapper who is mapping based on imagery can't expect to be able to fill in all fields. This also applies to tracktype, maxspeed etc.
Railways are typically mapped by someone who is particularly interested in railways, and who likely knows which value to use.
Starting to map a railway network from scratch is rare, and in case of minor edits the values can likely be copied from nearby features with a little knowledge of the network structure..

@quincylvania
Copy link
Collaborator

@slhh I came up with #5734 as a potential solution for this and similar advanced-mapping scenarios.

@boothym
Copy link
Contributor

boothym commented Jan 30, 2019

(sorry for the delay)

@bhousel think you've misunderstood. I was referring to the ford option only in combination with a railway line - which will be a very uncommon situation on the ground! :)

@quincylvania the number of casual mappers who can identify overhead line equipment (or third rail) from aerial imagery and would be put off by two extra fields appearing is probably quite small. I'd say it's more likely that they would try to find that information out, similar to the gauge field which is always shown for railway presets..

Plus there's the opposite situation where a mapper who knows about the railways, doesn't get shown the frequency/voltage fields and therefore doesn't realise it can be added to OSM.

The most likely scenarios are:

  • adding missing info to tracks near already electrified sections, like crossovers or where a second track is drawn instead of being tagged as tracks=2.

  • adding info to lines which have been newly electrified. Again this info can be found at either end of the line or by checking wikipedia. It also helps when all heavy rail electrification in Great Britain is 50Hz/25kV for contact line.

Anyway, let's see what happens. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

5 participants