-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing some fields for railway preset #4919
Comments
Also frequency and voltage fields should appear when selecting electrified=contact_line/rail in the dropdown |
Thanks for more informations |
We don't currently support having fields appear and disappear depending on values entered (Except for certain cases like the structure |
Is there a lot of work involved in adding the custom code for electrification? |
It would not be a lot of work to have the fields show up all the time and I think it's ok to expect the user to know whether to use them. |
Thanks - is it live in the preview to try? |
Yep! Since Frequency and Voltage aren't high priority I moved them to the "Add fields:" section. So first pick and Electrification value and then use the dropdown. If there are pre-existing values then the fields will appear regardless of the |
Hmm that's a bit of a regression to me. If someone sets a railway to electrified=contact_line or rail then they should immediately be shown the frequency and voltage fields below the electrified field (just like if you select "tunnel" you get more options). Though if were are considering low priority thing then how about removing the ford option from the structure field! :) |
Just because you don't use it doesn't mean we need to make someone else unhappy by removing it. |
It is an extra step to add these fields but I hope we can give the change a chance. I'm imaging a casual mapper identifying overhead contact lines in imagery and setting that Electrification value. Then two new fields immediately pop up that require research or domain-specific knowledge? Not the best experience. |
A mapper who is mapping based on imagery can't expect to be able to fill in all fields. This also applies to tracktype, maxspeed etc. |
(sorry for the delay) @bhousel think you've misunderstood. I was referring to the ford option only in combination with a railway line - which will be a very uncommon situation on the ground! :) @quincylvania the number of casual mappers who can identify overhead line equipment (or third rail) from aerial imagery and would be put off by two extra fields appearing is probably quite small. I'd say it's more likely that they would try to find that information out, similar to the gauge field which is always shown for railway presets.. Plus there's the opposite situation where a mapper who knows about the railways, doesn't get shown the frequency/voltage fields and therefore doesn't realise it can be added to OSM. The most likely scenarios are:
Anyway, let's see what happens. :) |
https://wiki.openstreetmap.org/wiki/Tag:railway%3Drail
usage=#
frequency=# (with electrified=contact_line/rail)
voltage=# (with electrified=contact_line/rail)
The text was updated successfully, but these errors were encountered: