Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to iD v2.8.0 #1821

Merged
merged 3 commits into from
Apr 16, 2018
Merged

Upgrade to iD v2.8.0 #1821

merged 3 commits into from
Apr 16, 2018

Conversation

bhousel
Copy link
Member

@bhousel bhousel commented Apr 16, 2018

No description provided.

@bhousel
Copy link
Member Author

bhousel commented Apr 16, 2018

2.8.0

April 16, 2018

📣 Release Highlights

  • 💬 We've changed how things look on the post-upload screen. Now after saving your edits,
    you will see a list of OpenStreetMap communities that are active around the area where you are editing.

    Reach out to nearby mappers and say hello!

💥 Breaking Changes

  • Drop support for node 4 / npm 2 (#4853)
    • ⚠️ If you are building the iD project, you will need to upgrade your node version.

🎉 New Features

  • Post-upload dialog improvements, and community index integration (#4815)
    • Social sharing options are gone (was: share your edit on Facebook, Twitter, Google+)
    • Community resources are displayed from most local to global
    • Nice icons come from FontAwesome
    • Each resource has a name, short description, and extended description (all available for translation)
    • Each resource can include a list of which languages are spoken (currently displays language codes)
    • Resources can optionally have events. If events exist, the next upcoming 2 will be shown.
    • Events can have a name, description, where, when
    • Events can optionally be translated (this would be more useful for a big event like a State of the Map)
  • Send more information about iD presets to Taginfo service - fields, geometries, icons (#4940, #4937, #3598, thanks @mmd-osm)
  • Remember changeset source tag value, make it settable via url param (#4899)

✨ Usability

  • Show a message on the History Panel if the selected feature is new (#4975)
  • Don't click cycle through alternating or reversible oneway states (#4970)
  • Fix zoom scaleExtent to allow zoom out to z2 (full world) (#4959)
  • Rename "No Turns" to "Only Straight On", add "Only U-turn" preset and icon (#4952)
  • Don't autocomplete numeric values in the combobox (#4935)
  • Hide Turn Restriction field on trivial junctions (#4934)
  • Add 'X' to close side panes (Background, Map Data, Help) (#4913, #4599, thanks @vershwal)
  • Add pencil "edit" icon to custom background item (#4908, #4798, thanks @vershwal)
  • Add hint alt text for "remove", "undo", "info" buttons (#4904, #4833, #4892 thanks @vershwal)

🐛 Bugfixes

  • Prevent node drags from breaking many kinds of relations / turn restrictions (#4921)
  • Fix bug preventing adding restrictions when multiple via paths exist (#4968, #4969, thanks @tyrasd)
  • Guard code to avoid deleting a turn twice (#4968, #4928)
  • When connecting nodes, prefer to keep an existing (not new) node (#4974, #4674)
  • When boundaries are shared with roads, consider them as roads for purposes of filtering (#4973)
  • Fix bug when deleting an only restriction on a bidirectional road (#4951)
  • Prevent clicking in restriction editor from selecting nearby text
  • Handle "entry only" and "exit only" variants of 'stop' and 'platform' when identifying PTv2 members (#4946)
  • Fix ';'-space delimiting within conditional opening hours style files, add tests (#4925)

🚀 Presets

@tomhughes
Copy link
Member

Something doesn't seem to be quite right - when I try uploading a changeset the upload is completed, and the side panel changes to the thank you message but the upload overlay with the spinner remains on screen and I can't do anything.

@bhousel
Copy link
Member Author

bhousel commented Apr 16, 2018

Thanks for checking @tomhughes - Do you have a mirror where I can test?
I tried on http://preview.ideditor.com/release/ with the released code and it seems ok.

Also, around where did you upload your changeset? We have some location specific community code now in the post-save screen.

@tomhughes
Copy link
Member

I think that http://dev.osm.compton.nu/edit#map=17/51.75210/-0.00886 might work but if it doesn't then I'll try pushing the code up to dev.

Coordinates are as above. I see it saying the name of the nearest town in the side panel but not any local groups. There don't seem to be any ongoing network requests.

@bhousel
Copy link
Member Author

bhousel commented Apr 16, 2018

Thanks, I can see what the issue is now - there are no communities there in the index, so the array is empty.. I'll push a fix.

@bhousel
Copy link
Member Author

bhousel commented Apr 16, 2018

I just republished v2.8.0 with the fix for the empty array - thanks for finding that @tomhughes !

@tomhughes tomhughes merged commit 30424e8 into openstreetmap:master Apr 16, 2018
@bhousel bhousel deleted the iD-2.8.0 branch December 4, 2018 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants