Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create antenna.json #4938

Merged
merged 1 commit into from
Mar 25, 2018
Merged

Create antenna.json #4938

merged 1 commit into from
Mar 25, 2018

Conversation

obama
Copy link
Contributor

@obama obama commented Mar 25, 2018

@bhousel bhousel merged commit 17bbf0a into openstreetmap:master Mar 25, 2018
@bhousel
Copy link
Member

bhousel commented Mar 25, 2018

Thanks @obama 👍

@1ec5
Copy link
Collaborator

1ec5 commented Mar 27, 2018

#2613 added a preset that could also be called “antenna” (and has been translated as such in at least one language). My understanding is that a standard guyed radio antenna would be tagged man_made=mast, as supported by openstreetmap-carto. Back when I added the preset, that would’ve been consistent with this wiki page, although the page has since been pared back; a separate page now describes the much rarer man_made=antenna tag and equivocates as to which tag should be used. So now I’m confused, and I can’t imagine the situation would be any better for the user. 😕 The documentation could be improved, as usual, but I think we might also need to adjust the two presets so that the distinction is clearer.

@bhousel
Copy link
Member

bhousel commented Mar 27, 2018

My understanding is that a standard guyed radio antenna would be tagged man_made=mast, as supported by openstreetmap-carto. Back when I added the preset, that would’ve been consistent with this wiki page, although the page has since been pared back; a separate page now describes the much rarer man_made=antenna tag and equivocates as to which tag should be used. So now I’m confused, and I can’t imagine the situation would be any better for the user.

Hey @1ec5 - yes, this situation is pretty confusing. Also remember in #3630 that we changed them from "Radio Mast" to simply "Mast".

I was assuming that Mast/Tower is the structure, and Antenna is the thing that attaches to it? Many people will only tag the Mast/Tower, as its the most visible thing.

@obama Can you discuss more your motivation for wanting this preset?

For reference:
https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dantenna
https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dtower
https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dmast

@obama
Copy link
Contributor Author

obama commented Mar 27, 2018

i thought it was OK to add, but if it confuses people than leave it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants