Dropdown for royal_cypher doesn't show most popular values

[lakedistrictOSM]

When royal_cypher is added in all tags, it doesn't show the most popular values in the dropdown.

This is what it shows:

These are the top values (from taginfo) which it should show:

It seems to ignore the values in all caps for some reason.

[bhousel]

Oh yeah this is like #3377
Most of the time iD ignores results from taginfo that begin with capital letters, but we have a whitelist for tags that are allowed to autocomplete this way.

I wrote on that issue:
For most fields in OSM (cuisine, religion, denomination) it's the behavior we actually want.
e.g. prefer "french" instead of "French"... prefer "catholic" over "Catholic".

[pnorman]

Whitelisting is the easy solution - perhaps an inherently "more correct" one is to ignore the one with capital letters when case insensitive matches something earlier in the list.

I'd probably just edit the whitelist ;)

[bhousel]

I'd probably just edit the whitelist ;)

Yep - the history for this line of code is pretty great..

iD/modules/services/taginfo.js

Lines 263 to 267 in a5b8e4b

	// In most cases we prefer taginfo value results with lowercase letters.
	// A few OSM keys expect values to contain uppercase values (see #3377).
	// This is not an exhaustive list (e.g. `name` also has uppercase values)
	// but these are the fields where taginfo value lookup is most useful.
	var re = /network|taxon|genus|species|brand|grape_variety|rating|:output|_hours|_times/;

A more correct solution would probably be to filter whatever we receive from taginfo and keep only the most popular string in situations where there are multiple strings that disagree in how they are cased.

[bhousel]

I ended up just adding it to the whitelist and closing the issue