Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make geolocate button show the location #5587

Closed
bhousel opened this issue Dec 11, 2018 · 0 comments · Fixed by #5629
Closed

Make geolocate button show the location #5587

bhousel opened this issue Dec 11, 2018 · 0 comments · Fixed by #5629
Assignees
@maxgrossman
Labels
usability An issue with ease-of-use or design

Comments

@bhousel
Copy link
Member

bhousel commented Dec 11, 2018

The geolocate control should work like every other app out there and show a blue puck where the user is with a circle around it. The button should toggle on/off the puck.

Talking about this thing:
screenshot 2018-12-11 10 27 52
@bhousel bhousel added the usability An issue with ease-of-use or design label Dec 11, 2018
@bhousel bhousel changed the title Make geolocate control show the location Make geolocate button show the location Dec 11, 2018
@maxgrossman maxgrossman self-assigned this Dec 18, 2018
maxgrossman added a commit that referenced this issue Dec 19, 2018
@maxgrossman
adding svg layer...
02261c9 
ref #5587
maxgrossman added a commit that referenced this issue Dec 19, 2018
@maxgrossman
working on geolocate layer
b7f0d86 
ref #5587
maxgrossman added a commit that referenced this issue Dec 19, 2018
@maxgrossman
implement point/puck geolocation
b9ddfca 
ref #5587
@maxgrossman maxgrossman mentioned this issue Dec 19, 2018
Merged
maxgrossman added a commit that referenced this issue Dec 19, 2018
@maxgrossman
update layers test for new geolocate svg layer
b010f42 
ref #5587
maxgrossman added a commit that referenced this issue Dec 19, 2018
@maxgrossman
just call accuracy function when setting r attr
83c0843 
ref #5587
maxgrossman added a commit that referenced this issue Dec 19, 2018
@maxgrossman
remove unused vars
3755951 
ref #5587
maxgrossman added a commit that referenced this issue Dec 19, 2018
@maxgrossman
remove dispatched changes and re-order layers
399e778 
ref #5587
@quincylvania quincylvania mentioned this issue Jan 23, 2019
Merged
@quincylvania quincylvania mentioned this issue Feb 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxgrossman maxgrossman

Labels
usability An issue with ease-of-use or design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5587 - make geolocation show geolocation openstreetmap/iD
2 participants
@bhousel @maxgrossman