Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support public domain icons from The Noun Project #5691

Closed
bhousel opened this issue Jan 9, 2019 · 3 comments
Closed

Support public domain icons from The Noun Project #5691

bhousel opened this issue Jan 9, 2019 · 3 comments
Assignees
Labels
chore-build Improvements to the iD build scripts / CI environment
Milestone

Comments

@bhousel
Copy link
Member

bhousel commented Jan 9, 2019

I saw this release of public domain humanitarian icons today - some of them are pretty nice.

The Noun Project is interesting, and I have mixed feelings about it.
Most icons there do not match the style of the other icons that we use in iD, but occasionally there are some that might be useful.

They do have an API (docs) and it looks like it would allow us to do this:

  • use the free tier up to 5000 calls/month
  • svg download available for public domain icons (the only ones we'd use anyway)

So I'm considering some limited support for using Noun Project icons as preset icons, as long as they are public domain, and we script occasional downloads into our repo.

@bhousel bhousel added considering Not Actionable - still considering if this is something we want chore-build Improvements to the iD build scripts / CI environment labels Jan 9, 2019
@quincylvania
Copy link
Collaborator

This would be great to do for the next release in order to differentiate more presets. With the favorite preset buttons in #6010 the user has to hover over identical icons to see what the preset is.

screen shot 2019-03-05 at 10 29 34 am

@bhousel bhousel self-assigned this Mar 5, 2019
@quincylvania quincylvania self-assigned this Apr 16, 2019
@quincylvania quincylvania removed the considering Not Actionable - still considering if this is something we want label Apr 17, 2019
@quincylvania quincylvania added this to the 2.15.0 milestone Apr 17, 2019
@bhousel
Copy link
Member Author

bhousel commented Apr 17, 2019

This is awesome - Thanks @quincylvania 👏

@quincylvania
Copy link
Collaborator

@bhousel Yes! It's exciting to have a new icon source. Unfortunately, it looks like most icons on there aren't public-domain and there's no way to filter by license, which makes finding compatible icons difficult. Their API does have a search endpoint where you can filter by public domain, so we could theoretically build a search tool.

I was wondering if we could also use CCBY icons and put the attribution somewhere, but the API won't let you download those SVGs on a free account anyway so there's not much point in looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore-build Improvements to the iD build scripts / CI environment
Projects
None yet
Development

No branches or pull requests

2 participants