Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable preset buttons for hidden layers #5876

Closed
quincylvania opened this issue Feb 8, 2019 · 3 comments
Closed

Disable preset buttons for hidden layers #5876

quincylvania opened this issue Feb 8, 2019 · 3 comments
Assignees
@quincylvania
Labels
usability An issue with ease-of-use or design
Milestone
2.14.0

Comments

@quincylvania
Copy link
Collaborator

It's not always obvious when a set of map features are hidden. This can lead to users re-mapping features that are already mapped but not shown. This is especially an issue with buildings, since they will automatically be hidden if there are too many.

We should disable the presets associated with the hidden layers, showing a tooltip on hover that informs users of the situation.

screen shot 2019-02-08 at 4 15 27 pm

screen shot 2019-02-08 at 4 10 01 pm
@bhousel
Copy link
Member

bhousel commented Feb 9, 2019

yeah this is actually kind of #2711 too
I like your mockup of disabling the buttons better than my crappy mockup in that thread. 😆

@quincylvania
Copy link
Collaborator Author

Oh yeah this is definitely #2711—I missed that! I'll leave this open anyway so we can target this solution.

@quincylvania quincylvania added the usability An issue with ease-of-use or design label Feb 11, 2019
@bhousel bhousel mentioned this issue Feb 11, 2019
Closed
@quincylvania quincylvania self-assigned this Feb 12, 2019
@quincylvania quincylvania added the wip Work in progress label Feb 12, 2019
@quincylvania quincylvania mentioned this issue Feb 12, 2019
Merged
@quincylvania quincylvania removed the wip Work in progress label Feb 12, 2019
@quincylvania quincylvania added this to the 2.14.0 milestone Feb 12, 2019
@quincylvania
Copy link
Collaborator Author

This is the UI I added. It works for both manually and automatically hidden layers.

screen shot 2019-02-20 at 1 13 37 pm

screen shot 2019-02-20 at 1 13 00 pm

@quincylvania quincylvania mentioned this issue Feb 20, 2019
Merged
@quincylvania quincylvania mentioned this issue Mar 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quincylvania quincylvania

Labels
usability An issue with ease-of-use or design
Projects
None yet
Milestone
2.14.0
Development

No branches or pull requests
2 participants
@bhousel @quincylvania