Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable preset buttons for hidden layers #5884

Merged
merged 3 commits into from
Feb 12, 2019
Merged

Disable preset buttons for hidden layers #5884

merged 3 commits into from
Feb 12, 2019

Conversation

quincylvania
Copy link
Collaborator

Closes #5876.

It'd be great to get a review since this changes some rather hot code.

screen shot 2019-02-12 at 2 41 56 pm

screen shot 2019-02-12 at 2 41 09 pm

@quincylvania quincylvania self-assigned this Feb 12, 2019
@quincylvania quincylvania added the usability An issue with ease-of-use or design label Feb 12, 2019
bhousel
bhousel reviewed Feb 12, 2019
View reviewed changes
Copy link
Member

@bhousel bhousel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems mostly ok 👍

modules/renderer/features.js Outdated Show resolved Hide resolved
@quincylvania quincylvania merged commit 24341dd into master Feb 12, 2019
@quincylvania quincylvania deleted the disable-preset-buttons-for-hidden-layers branch February 12, 2019 20:17
@quincylvania quincylvania added this to the 2.14.0 milestone Feb 12, 2019
@quincylvania quincylvania mentioned this pull request Feb 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhousel bhousel bhousel left review comments

Assignees

@quincylvania quincylvania

Labels
usability An issue with ease-of-use or design
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@quincylvania @bhousel