Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow recently used presets to be dragged and dropped into the favorite presets bar #6044

Closed
BjornRasmussen opened this issue Mar 12, 2019 · 12 comments
Assignees
Labels
tools Something for the taskbar/toolbar
Milestone

Comments

@BjornRasmussen
Copy link
Contributor

BjornRasmussen commented Mar 12, 2019

image
Dragging the "parking aisle" icon into the favorites bar (which currently had node, line, and area) is impossible. This motion is very intuitive, and would be a simple way to make a recently used preset a favorite.
image

@bhousel
Copy link
Member

bhousel commented Mar 21, 2019

Closing here, I think they just appear in the "Recent" area of the ribbon now..

@bhousel bhousel closed this as completed Mar 21, 2019
@quincylvania
Copy link
Collaborator

This is actually something I do want to get to eventually…

@quincylvania quincylvania reopened this Mar 21, 2019
@bhousel
Copy link
Member

bhousel commented Mar 21, 2019

oh ok.. Sorry, I'm just going through and closing a lot of things because I'm pretty overwhelmed by the issue list right now.

@quincylvania
Copy link
Collaborator

After using the ribbon for a few months, I'm still not sure I love splitting the quick presets into separate groups.

Screen Shot 2019-08-02 at 3 49 07 PM

I mocked up an alternative that I'd like to get feedback on. It keeps all quick presets in a continuous strip. There's now room to use the preset names as labels, abbreviated as needed. This helps differentiate presets with the same icon, especially on mobile where the tooltips are inaccessible.

Screen Shot 2019-08-02 at 1 55 57 PM

When you click the label area, it can toggle to the number shortcuts for advanced users.

Screen Shot 2019-08-02 at 1 56 08 PM

The favorites could be specified via badges, as inspired by the Mario Maker 2 UI. This would also let the mapper mix the order of recents and favorites. For example, you may want to always keep 1 as your most recent, followed by your favorites.

Screen Shot 2019-08-02 at 3 47 33 PM

@BjornRasmussen
Copy link
Contributor Author

BjornRasmussen commented Aug 3, 2019

I personally don't like either ribbon. Here's why:
When editing, the recent quickly gets very long. The ribbon is then filled with 10 separate presets. This is quite cluttered, however, and since the recent presets keep moving around, it's hard to memorize the different shortcuts. Looking for the preset is also hard, because the ribbon is so cluttered.
Because of this, I don't use recent presets from previous sessions often. Instead, I often clear them out by dragging and dropping to make the ribbon less cluttered, and then adjust the favorites bar to whatever I'm mapping.

EDIT:

I can think of several solutions to this:

  1. Don't save recent presets between editing sessions since they aren't as useful, but still take up space.
  2. Remove the recent presets ribbon, and place the recent presets in the search results in "Add feature" instead. I don't really like this solution, though, because it would mix recent presets with suggestions based on context, making the search area more cluttered.

@slhh
Copy link
Contributor

slhh commented Aug 3, 2019

@quincylvania
I would keep the Favorites and Recent sections separate, and make the separation dragable to adjust the number of shown recents. The labeling of the sections isn't essential, users will get used to it anyway. You might drop it in favor of preset names or shortcuts. Maybe section lables can be shown while dragging the separation.
Missing tooltips on mobile are a problem, but I'm not sure whether such short preset names labels do really work well, and this is likely language dependent.

If recents were dragable into favorites as requested in this issue, displaying a single recent would likely be a useful setting.

Assigning shortcuts to recents seems to be of very limited use. Maybe, shortcut 0 can be assigned to the most recent one, and no shortcut to the other recent ones. This is easy to memorize, and might give users a safer feeling when using shortcuts.

@BjornRasmussen
Copy link
Contributor Author

Adding to my last comment, I still find the "recent" presets very useful when I first start editing and there aren't any presets still around from previous sessions, because I quite often add the same thing several times in a row. The real issue is that I never use the recent shortcuts from previous editing sessions - they just sit there cluttering up the UI.

@quincylvania
Copy link
Collaborator

quincylvania commented Aug 7, 2019

I think let's keep Favorites and Recents separate for now. This division seem pretty straightforward to understand. We could still cycle to the number shortcuts (and possibly the short preset names) when you click on the button labels.

@BjornRasmussen I agree that shortcuts are useful for getting started but can outlive their usefulness. Originally I had the recents maxing out at 5 instead of 10, maybe this would be better? Also, once we do #6717 then you could hide the recents at any time.

@quincylvania quincylvania added the tools Something for the taskbar/toolbar label Aug 7, 2019
@BjornRasmussen
Copy link
Contributor Author

Maximg out the recents at 5 good! Does not tracking recent searches between changesets also seem reasonable? I know that there was an issue about doing the opposite of this a while back, but that was before the ribbon UI.

@quincylvania
Copy link
Collaborator

@BjornRasmussen I think persisting the recents between changesets/sessions is more useful than not. Some mappers might focus on the same few things but not bother to favorite them. Though we could clear them out after a few days of not editing (like we do with unsaved changeset comments). We also might have a "Clear All" option for recents if we do #6024.

@quincylvania quincylvania added this to the 3.0.0 milestone Aug 27, 2019
@quincylvania quincylvania self-assigned this Aug 27, 2019
@jidanni
Copy link
Contributor

jidanni commented Oct 5, 2019

I see no favorites bar.
Perhaps it is an unreleased feature.

@leifr-unc
Copy link

Yes, see https://preview.ideditor.com/master

@quincylvania quincylvania modified the milestones: v3 prototype, 3.0.0 Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Something for the taskbar/toolbar
Projects
None yet
Development

No branches or pull requests

6 participants