Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible Oneways - flag waterways, etc with improper direction #6216

Closed
bhousel opened this issue Apr 23, 2019 · 3 comments
Closed

Impossible Oneways - flag waterways, etc with improper direction #6216

bhousel opened this issue Apr 23, 2019 · 3 comments
Assignees
Labels
validation An issue with the validation or Q/A code
Milestone

Comments

@bhousel
Copy link
Member

bhousel commented Apr 23, 2019

Screenshot 2019-04-23 01 26 42

I guess we could do this for other directional things too:

  • oneway roads
  • pistes / ski lifts
@bhousel bhousel added the validation An issue with the validation or Q/A code label Apr 23, 2019
@bhousel bhousel changed the title Flag waterways (and others?) with improper direction Impossible Oneways - flag waterways, etc with improper direction Apr 23, 2019
@quincylvania quincylvania self-assigned this Apr 25, 2019
@Nakaner
Copy link

Nakaner commented Apr 26, 2019

The cases shown above is only an error if it is located inside the area downloaded in the editor. This should be taken into account by the implementation of that validation rule.

@quincylvania
Copy link
Collaborator

@Nakaner Good point. @bhousel added checks to ignore ways with nodes on undownloaded tiles for #5938, so we can use that code.

@quincylvania
Copy link
Collaborator

I did this for highways and waterways. Pistes and aerialways seem more prone to edge cases and less common anyway so I held off on those for now.

Screen Shot 2019-04-26 at 12 09 43 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

3 participants