Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 title bar: ability to drag&drop generic item buttons to left side of new "Add feature" / search-button #6458

Closed
sun-geo opened this issue May 30, 2019 · 10 comments
Assignees
Milestone

Comments

@sun-geo
Copy link
Contributor

sun-geo commented May 30, 2019

It seems i'm still an old school user of iD and always happy to not loose hundred per cent of the great history of iD and the rawish workflow. ;-)
Could use please let me drag&drop the “Favorites” buttons for adding the 3 generic items (node, line & area) to the left side of the new "Add feature" / search-button?

And if they fall down to these left hand side, please increase the width of these 3 buttons, at least to the same width of the current "Add feature" / search-button.

Screenshot
node left side

@quincylvania
Copy link
Collaborator

@sun-geo Does it make a difference in your workflow that these are on the right side instead of the left side? The keyboard shortcuts are the same. I'd really prefer not to privilege the generic presets over the normal ones.

@sun-geo
Copy link
Contributor Author

sun-geo commented May 30, 2019

regarding the button width...

before
before

after
after

@sun-geo
Copy link
Contributor Author

sun-geo commented May 30, 2019

quincylvania: "Does it make a difference in your workflow that these are on the right side instead of the left side? The keyboard shortcuts are the same. I'd really prefer not to privilege the generic presets over the normal ones."

Hmm not 100% sure yet, but does it make a difference of other users they don't use the generic item button at all?

@quincylvania
Copy link
Collaborator

does it make a difference of other users they don't use the generic item button at all?

Maybe not, but any new feature requires an investment of initial development and long-term support.

Our goal with iD v3 is to build a next-generation editor, and sometimes this may mean changing old functionality. In this case the functionality is backwards-compatible. Can we give this some time and see how people feel?

@quincylvania quincylvania added the considering Not Actionable - still considering if this is something we want label May 30, 2019
@sun-geo
Copy link
Contributor Author

sun-geo commented May 30, 2019

Yes, I understand to get a "real" change of UI especially when there will be happen an increase of v2 to v3.
But i think you did already a lot & hard work for the new features

  • Recent, Repeat, Search,
  • changing availability/grey out for buttons (like Segments, Undo&Redo, Finish, Deselect, Circularize, Square and so on) which already exist now & which will already legitimate the change from v2 to v3 in my opinion :-)

An other minor proposal, maybe the wording from "Favorites" to "Add basic element" (or somewhat) could be modified, see here:
after2

I assume new iD-users will even newer see these generic buttons, if they don't need/like it...

@quincylvania quincylvania added this to the 3.0.0 milestone Sep 17, 2019
@quincylvania quincylvania removed the considering Not Actionable - still considering if this is something we want label Sep 17, 2019
@quincylvania quincylvania self-assigned this Sep 17, 2019
@quincylvania
Copy link
Collaborator

quincylvania commented Sep 17, 2019

@1ec5 wrote this in OSMUS Slack:

I get why the workflow is oriented towards presets over geometry types and appreciate that there’s still a toggle while using a preset. But I think the paradigm shift is a tradeoff rather than an unqualified improvement. Some people are certainly going to find it more intuitive to focus on the type of business rather than the geometry.

On the other hand, there are people who benefit from the current workflow, which is more like a drawing program. (In Illustrator, you choose the drawing tool and draw before choosing the stroke color, dash pattern, etc.)

Potlatch compromised by having both a palette of presets and affordances for drawing before tagging, to accommodate both ways of thinking. The new drawing modes in v3 like repeat have me imagining a drawing-first mode as an option that wouldn’t be as prominent as the presets. It’s still possible to favorite the point/way/area presets, but that feels like a hacky workaround.

And I think he might have a point! I think there are great possibilities for the new workflow but perhaps the old one has its place. In any case, we did #6717 so now we can have a single toolbar item to recreate the legacy workflow. It's enabled by default upon upgrade from iD 2 but disabled by default for new users.

Screen Shot 2019-09-17 at 6 20 54 PM

("Base Types" may not be the best name for this but I thought it better than "Generics".)

@1ec5
Copy link
Collaborator

1ec5 commented Sep 18, 2019

("Base Types" may not be the best name for this but I thought it better than "Generics".)

It is better than “Generics”. Other options could be “Add Shape”, “Geometries”, or “Drawing Tools”.

@bhousel
Copy link
Member

bhousel commented Sep 18, 2019

I really like this a lot, thanks @quincylvania !
FWIW I like "Geometries"

@sun-geo
Copy link
Contributor Author

sun-geo commented Sep 18, 2019

Thanks for adding these new options (checkboxes), even if my initial request (possibility of dragging the base types to left side and increasing width for base type buttons would not implemented) Meanwhile I'm ok to let it like it is now.

Regarding the wording. I still would prefer to maybe use/have the same wording like the wiki is using.
https://wiki.openstreetmap.org/wiki/Elements
But I know & i see there is a little difference between these types
iD-editor offers: point, line, area
wiki-elements: node, way, relation

@quincylvania
Copy link
Collaborator

I really like this a lot, thanks @quincylvania !

@bhousel Good, I hope it helps!

FWIW I like "Geometries"

Agreed, let's try this for awhile.

Thanks for adding these new options (checkboxes), even if my initial request (possibility of dragging the base types to left side and increasing width for base type buttons would not implemented)

@sun-geo Now that we have an advanced toolbar system some of this might actually be possible. I'm sure at some point someone will request the ability to reorder toolbar items. We might also consider showing the preset/geometry names when there's space.

Also note: you can hide the Add Feature tool and only use the generic workflow if you want!

Regarding the wording. I still would prefer to maybe use/have the same wording like the wiki is using.

We couldn't really do this even if we wanted to since the types don't map directly—OSM doesn't have an area type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants