Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data structure for feature groups #6528

Closed
quincylvania opened this issue Jun 12, 2019 · 0 comments · Fixed by #6534
Closed

Add data structure for feature groups #6528

quincylvania opened this issue Jun 12, 2019 · 0 comments · Fixed by #6534
Assignees
Labels
chore-build Improvements to the iD build scripts / CI environment
Milestone

Comments

@quincylvania
Copy link
Collaborator

Currently, iD has a mechanism for matching a feature to one and only one preset. It's straightforward for new contributors to add new presets since they are easily defined in JSON.

However, a single preset does not fully define a feature. Features can be sorted into multiple "groups" based on their tags and geometry. iD now defines these variously in code, for example:

  • Toggle-able Map Data layers
  • Routable features
  • Implied one-way features

We should move these to JSON files as part of #6483 and #5326.

Each group can have rules that define what features to include and qualities that specify what the features have in common. iD can then match each feature into a number of groups and adjust behaviors based on them.

@quincylvania quincylvania added the chore-build Improvements to the iD build scripts / CI environment label Jun 12, 2019
@quincylvania quincylvania self-assigned this Jun 12, 2019
@quincylvania quincylvania added this to the 3.0.0 milestone Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore-build Improvements to the iD build scripts / CI environment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant