-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize iD #6483
Comments
Actually I'd prefer for everything substantial to move out of this repo into a new one, and this repo under the openstreetmap organization could just be where the plugin lives. |
How would translations in Transifex become organized with this change? |
@manfredbrandl Most likely the core iD strings and the OpenStreetMap-specific strings would be separated out. The iD strings would remain on transifex while the OSM strings could become a separate transifex project or use another translation platform like the wikibase. |
Would this generic editor use name of OSM editor or is there a plan to create a new name? |
It would just be "iD", right? |
@matkoniecz I haven't thought much about the names. I think the core would be "iD" and then plugin could be "iD for OpenStreetMap" or something. |
This would be really useful for us. We currently maintain a fork for integration with our offline map editor, Mapeo. Generalizing iD and splitting into separate modules would make customization much easier to maintain. The key would be well-designed APIs for each module which remain as stable as possible. We would love to help out, although we have no one on our team at the moment who is very familiar with the iD codebase. |
I really like the idea of splitting up the core application from presets and other the metadata into separate repositories. Looking forward to it. Just to add my 5 cents, here are the advantages I see:
* for example:
|
Yes, we will still do this as part of modularization. The presets that we bundle now are too big and it would be better to have smaller preset packs for users to add on depending on whatever their needs are. (As an aside, I think the suggestion to build a "custom made solution" to replace what we get from Transifex would be a mistake. There is a ton of work that has been done to translate all of the presets, and it would be great to try to retain that.) For completeness, here are the criticisms we got the last time we offered to split out the iD presets in 2015. My take on this is that other downstream projects are either already consuming the presets directly from iD (so having them in the iD repository isn't really a blocker) or are not interested in them anyway (JOSM). It helps us to have them more tightly coupled with iD so we can change things about them sometimes (stuff like #6124 is a good example). |
Would there be any demand for a separate NPM package for the presets that is still developed in the iD repository, monorepo-style? |
Currently, iD is designed for mapping OpenStreetMap data exclusively. This severely limits the downstream use cases of the project.
We should make iD a general-purpose GeoJSON editor with an extensive plugin interface. Developers could then customize every part of iD without even needing to fork it. The OpenStreetMap plugin would be the flagship plugin and could live in a separate repo. That way, things like presets and tag deprecations could be hashed out separately from the iD core.
From the perspective of a user editing on osm.org, this change would make no difference.
Some of the components that require generalizing:
The text was updated successfully, but these errors were encountered: