Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use iD presets as the source for this #2

Closed
wants to merge 1 commit into from
Closed

Conversation

bhousel
Copy link
Member

@bhousel bhousel commented Jul 9, 2015

This PR brings in the iD presets, fields, and build scripts. If accepted, I'll remove these things from iD and make this repository the master source for iD's presets.

RE: openstreetmap/iD#2656

@pnorman
Copy link

pnorman commented Jul 9, 2015

is the iD format sufficiently rich to convert to the various editor formats? Should they be stored in here in some other format, and converted to the iD format and JOSM format by scripts?


```javascript
{
// Maki icon which represents this feature.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about non-Maki icons?

@HolgerJeromin
Copy link

The diskussion on the josm dev ML is interesting about this. JOSM uses a more advanced preset system which can not generated from iD presets.

@bhousel
Copy link
Member Author

bhousel commented Jul 9, 2015

is the iD format sufficiently rich to convert to the various editor formats? Should they be stored in here in some other format, and converted to the iD format and JOSM format by scripts?

Somebody would have to define the format and write the scripts. As I've said before, a new format solves a problem that nobody has.

@bhousel
Copy link
Member Author

bhousel commented Jul 9, 2015

The diskussion on the josm dev ML is interesting about this. JOSM uses a more advanced preset system which can not generated from iD presets.

Yes I've seen it, I don't think anybody is expecting JOSM to get involved in this effort - and their code and presets are license-incompatible anyway.

Someone (I can't remember who) wrote scripts to turn the iD presets into JOSM ones - I expect that's the best way forward for users who want to use these presets in JOSM.

@bhousel
Copy link
Member Author

bhousel commented Jul 9, 2015

I thought about it more and realized - I just did a dumb copy when I made this and instead probably should have done something a bit more clever to preserve the git history of the files. After discussion shakes out, I may redo this PR..

@pnorman
Copy link

pnorman commented Jul 9, 2015

If this is only going to work with iD, what's the point? The JOSM license isn't a blocker, as that stops this repo from using the existing JOSM presets, not this repo from producing JOSM preset files.

@HolgerJeromin
Copy link

This repository content can have the licence we want. Imo it would be possible to have josm presets with its license and use this even in iD. Vespucci uses different licenses for the code and the preset images.
I don't see the that this should not be possible with id, too.

@pnorman
Copy link

pnorman commented Jul 9, 2015

Imo it would be possible to have josm presets with its license and use this even in iD.

If we're using the MIT license for this repo, we can have presets for JOSM, but not the JOSM presets.

@bhousel
Copy link
Member Author

bhousel commented Sep 28, 2015

Withdrawing this, as iD's presets have already moved significantly over the summer and there doesn't seem to be any interest.

@bhousel bhousel closed this Sep 28, 2015
@iandees
Copy link
Member

iandees commented Sep 28, 2015 via email

@bhousel
Copy link
Member Author

bhousel commented Sep 28, 2015

Ack, I completely forgot about this PR Bryan. If you opened it up again
with more recent data I would probably merge it. I definitely have interest.

Ok cool, I'll resubmit when I have better availability..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants