Make preset data an external dependency #8175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7702. Re: #6483.
This removes the presets, fields, deprecated tags, and discarded tag data files and instead makes iD depend on the new openstreetmap/id-tagging-schema package, which in turn depends on the ideditor/schema-builder package.
Moving presets and other tagging data outside iD has some clear advantages:
In the future, I'd like to see if we can move even more tagging logic out of iD's source code and into the tagging schema repo.