Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make preset data an external dependency #8175

Merged
merged 7 commits into from
Nov 10, 2020
Merged

Conversation

quincylvania
Copy link
Collaborator

Closes #7702. Re: #6483.

This removes the presets, fields, deprecated tags, and discarded tag data files and instead makes iD depend on the new openstreetmap/id-tagging-schema package, which in turn depends on the ideditor/schema-builder package.

Moving presets and other tagging data outside iD has some clear advantages:

  • Tagging issues can be detached from code issues
  • Other projects can depend on iD's presets directly
  • Developers can more easily create their own presets and plug them into iD
  • The latest presets could potentially be loaded at runtime instead of waiting for new releases

In the future, I'd like to see if we can move even more tagging logic out of iD's source code and into the tagging schema repo.

@quincylvania quincylvania added this to the Next Major Release milestone Nov 6, 2020
@quincylvania quincylvania self-assigned this Nov 6, 2020
@quincylvania quincylvania added preset An issue with an OpenStreetMap preset or tag chore-dependency Improvements to one of iD's dependencies labels Nov 6, 2020
@quincylvania quincylvania requested a review from bhousel November 6, 2020 16:05
@bhousel bhousel removed their request for review November 9, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore-dependency Improvements to one of iD's dependencies preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the presets folder into an own repository
1 participant