Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the "Zoom to this" text button #6601

Closed
quincylvania opened this issue Jul 1, 2019 · 3 comments
Closed

Replace the "Zoom to this" text button #6601

quincylvania opened this issue Jul 1, 2019 · 3 comments
Assignees
@quincylvania
Labels
tools Something for the taskbar/toolbar
Milestone
2.18.0

Comments

@quincylvania
Copy link
Collaborator

The current button looks sort of out of place and takes up vertical height. With the contextual toolbar, we can show a Zoom To item when a feature or note is selected.

Screen Shot 2019-07-01 at 11 23 15 AM
@quincylvania quincylvania added the tools Something for the taskbar/toolbar label Jul 1, 2019
@quincylvania quincylvania added this to the 3.0.0 milestone Jul 1, 2019
@quincylvania quincylvania self-assigned this Jul 1, 2019
@quincylvania
Copy link
Collaborator Author

This seems better.

Screen Shot 2019-07-01 at 1 08 57 PM

@bhousel
Copy link
Member

bhousel commented Jul 1, 2019

Nice 👍 I like this better too..

@sun-geo sun-geo mentioned this issue Jul 3, 2019
Closed
@quincylvania
Copy link
Collaborator Author

Reflecting more on this, it's not great for a zoom control to live alongside edit controls. I'm going to try putting this in the map alongside the other zoom controls. It'd be disabled when nothing is selected. We'll have the space after #7368.

Screen Shot 2020-02-26 at 4 21 14 PM

@quincylvania quincylvania changed the title Move the "Zoom to this" button to the toolbar Move the "Zoom to this" button out of the inspector Feb 27, 2020
quincylvania added a commit that referenced this issue Feb 27, 2020
@quincylvania
Move the "zoom to this" button from the inspector to the map next to …
5aab098 
…the zoom in/out buttons (re: #6601)

Use title case for the Zoom In and Zoom Out button labels
@quincylvania quincylvania mentioned this issue Feb 27, 2020
Merged
@quincylvania quincylvania changed the title Move the "Zoom to this" button out of the inspector Replace the "Zoom to this" text button Feb 27, 2020
zlavergne pushed a commit to KaartGroup/iD that referenced this issue Mar 10, 2020
@quincylvania @zlavergne
Move the "zoom to this" button from the inspector to the map next to …
2a1e441 
…the zoom in/out buttons (re: openstreetmap#6601)

Use title case for the Zoom In and Zoom Out button labels
@quincylvania quincylvania modified the milestones: 3.0.0, 2.18.0 May 5, 2020
@quincylvania quincylvania mentioned this issue Jul 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quincylvania quincylvania

Labels
tools Something for the taskbar/toolbar
Projects
None yet
Milestone
2.18.0
Development

No branches or pull requests
2 participants
@bhousel @quincylvania