LibreJS compatibility

[TechnologyClassroom]

It would be nice if iD became LibreJS compliant.

Instructions:

• Setting your JavaScript free
• Setting your JavaScript free from the LibreJS manual

[matkoniecz]

What would need to be changed?

Why it would be useful?

See openstreetmap/openstreetmap-website#2886

Comments such as

iD editor which is included in this repo has 74 direct dependencies: https://github.com/openstreetmap/iD/network/dependencies and many more indirect ones (some of which are only dev dependencies). Tagging those in the source code doesn’t seem feasible at all.

and

There are probably a hundred or more different pieces of javascript and they're changing all the time - we're not going to go round trying to catalogue them with some esoteric labels just because you're chosen to shoot yourself in the foot.

by people with experience in making software make me skeptical about this proposal.

[TechnologyClassroom]

Some indication that the code is available would be helpful at least. I did not know the frontend was freely licensed after using the site for several years. LibreJS is one solution. Simply adding a link to this repo would solve the need for most people.

When viewing the minified JS, the code is mostly useless and acts more like a binary in practice. Linking to the unminified version would help this issue. With minified JavaScript, the comments and variable names are removed making it very difficult to understand.

Can you point me to the process that bundles and minifies the JavaScript so I can get a better grasp on the process?

[kymckay]

@TechnologyClassroom The scripts in package.json are what you're looking for:

iD/package.json

Line 26 in 06441e7

"dist:min:iD": "uglifyjs dist/iD.legacy.js --compress --mangle --output dist/iD.min.js",

dist:min:iD handles minification (by calling uglifyjs), the file being minified (dist/iD.legacy.js) is output by rollup (bundler) via the build:legacy script:

iD/package.json

Line 20 in 06441e7

"build:legacy": "rollup --config config/rollup.config.legacy.js",

[quincylvania]

dist:min:iD handles minification (by calling uglifyjs), the file being minified (dist/iD.legacy.js) is output by rollup (bundler) via the build:legacy script:

This is true, but we actually sync the dist/iD.legacy.js file directly to openstreetmap-website, and then they run it through their own minification script. The dist/iD.min.js file is for other downstream apps that don't have their own compression workflow.

Some indication that the code is available would be helpful at least. I did not know the frontend was freely licensed after using the site for several years. LibreJS is one solution. Simply adding a link to this repo would solve the need for most people.

There's info in the help pane. We're not hiding that we're open source, we hope people see this and come contribute!

LibreJS sounds like a nice-to-have, but I doubt it affects many mappers at all, so it's really not a high priority. Since openstreetmap-website isn't pursuing compatibility, and since we have a lot of other stuff to worry about, I'm closing this as low impact. I'd still welcome a pull request if anyone is feeling inspired, provided the changes aren't breaking or hard to maintain.