-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibreJS compatibility #2886
Comments
Is there some javascript on our web site that you think is not under an open source license? I'm not aware of any. |
I hope not. This license tag change would affect users of the LibreJS extension. |
Perhaps if you explain exactly what it is you want instead of expecting me to read thousands of words of polemic it might be easier to assess your request. |
With LibreJS installed, I have to whitelist two external scripts, reload, whitelist a third script, and reload before the page works. Exact instructions would require a better understanding of how the JavaScript is served. Maybe web labels would be the best approach. An simple example of a script tag would look like this:
|
There are probably a hundred or more different pieces of javascript and they're changing all the time - we're not going to go round trying to catalogue them with some esoteric labels just because you're chosen to shoot yourself in the foot. |
Can you provide some insight into how JavaScript is handled by the project? Is JavaScript bundled by an upstream project? This is my first time interacting with the git, but I have promoted OSM, used the map daily, and have contributed changes to the OSM database for several years. |
iD editor which is included in this repo has 74 direct dependencies: https://github.com/openstreetmap/iD/network/dependencies and many more indirect ones (some of which are only dev dependencies). Tagging those in the source code doesn’t seem feasible at all. |
Right. Manually tagging all of these would be impractical. Some of those dependencies might be on the backend and would not need tagging. A programmatic approach would be best. iD's ARCHITECTURE.md says rollup.js is used as a bundler. Is that the piece that minifies JS and adds unique strings? |
It would be nice if OSM became LibreJS compliant.
Instructions:
Practical reasons for adding LibreJS compliance:
The text was updated successfully, but these errors were encountered: