-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPS sensitive URIs #2965
HTTPS sensitive URIs #2965
Conversation
@@ -117,7 +117,7 @@ iD.BackgroundSource.Bing = function(data, dispatch) { | |||
}; | |||
|
|||
bing.logo = 'bing_maps.png'; | |||
bing.terms_url = 'http://opengeodata.org/microsoft-imagery-details'; | |||
bing.terms_url = '//opengeodata.org/microsoft-imagery-details'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this has moved to:
https://blog.openstreetmap.org/2010/11/30/microsoft-imagery-details/
see also discussion on #2681 For outbound links and api endpoints, we need to make sure the resource is available over both Given that iD can sometimes be loaded locally, and Thoughts @jfirebaugh ? |
This So I think we wont need to do |
Please don't use protocol relative URLs -- as @bhousel said they fail for
|
9ea00ff
to
69262b0
Compare
@bhousel I have updated the patch. |
(closes openstreetmap#2960) Interim
Thanks this looks good! |
Support HTTPS URIs where available
change of all http:// URIs in js/id folder to //.
(closes #2960)