Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend presets with contact, SSID, mast, surveillance, lunch, taxon, add icons, extend .gitignore #3561

Closed
wants to merge 11 commits into from

Conversation

bkil
Copy link
Contributor

@bkil bkil commented Nov 6, 2016

Some small improvement inside data/presets

I commonly add these tags manually. All tags are accepted
and most of them are widely used.

By the way, do we have plans to help people transition from phone
and website to contact:phone, contact:website, etc? It would be
useful to show the old ones as well, but for newly created nodes,
the editor should definitely create these contact:* variants.

  • README: small typo fixes
  • add fields/internet_access/wlan/ssid.json
  • add presets/highway/traffic_mirror.json
  • fields/contact: add mail, fb, g+, Instagram, LinkedIn, Twitter, VK
  • add construction, height and icon to mast, tower
  • extend surveillance with camera properties, height
  • extend cafe, pub, restaurant, fast_food with lunch & contacts
  • add taxon to hedge, forest, heath, scrub, wood, tree*

Add icons to a few common POI

The end goal would be that when editing an area rich in POI, most of them
should have a different icon so that less point&clicking will be needed
to find the right one to extend.

To achieve this, all common POIs should have individual icons to serve as
mnemonics, and all POIs which are usually located near each other should
usually be assigned different icons.

Needed to replace the water icon with drinking-water.
I also liked the drop icon better, but it will be visually different
from non-drinkable sources this way.

.gitignore: hide automatically generated files

They are cluttering up pull requests and probably filling up the repo
as well.

Would this break anything? Could you tell me why we need them here?

Note

I didn't have time to test everything, I hope your suits can catch regressions.

The end goal would be that when editing an area rich in POI, most of them
should have a different icon so that less point&clicking will be needed
to find the right one to extend.

To achieve this, all common POIs should have individual icons to serve as
mnemonics, and all POIs which are usually located near each other should
usually be assigned different icons.
I also liked the drop icon better, but it will be visually different
from non-drinkable sources this way.
@bhousel
Copy link
Member

bhousel commented Nov 6, 2016

This is really too much for me to review. I'd prefer for ideas like this to be broken out into separate PRs.

Just at a very quick glance:

  • we probably want the typo fixes,
  • we probably want a few of the preset field additions, but not so many that it would clutter up the sidebar (you went way overboard by adding 'twitter', 'linkedin', 'vk', etc)..
  • I disagree with many of the icon changes because they seem less clear (like adding 'bus' for a ticket vending machine, or 'alcohol shop' for a drink vending machine
  • we need the checked in files because 1. some other places like taginfo and transifex pull them automatically from our repository. 2. there have been extensive discussions about what to check in based on previous issues.

So, I really do appreciate that you want to work on these things and I'd like to see you continue to contribute to iD, but I need your changes broken into smaller PRs, and it's really nice when things start out from an issue where we can discuss first, because I don't want you to waste your time on things I can't merge in.

By the way, do we have plans to help people transition from phone
and website to contact:phone, contact:website, etc?

No plans. I'd prefer the new namespaced ones, but I don't think they are widely used. OSM needs to come up with a plan to migrate the data before we change the fields.

@bhousel bhousel closed this Nov 6, 2016
@bhousel
Copy link
Member

bhousel commented Nov 7, 2016

@bkil FWIW, I did just go through all your commits and cherry pick some of the changes that I think are great..

6b77116 Add religious-christian icon to wayside_cross preset
37965f4 Adjust tower field labels, remove lighthouse icons
41b9afd data/presets: add construction, height and icon to mast, tower
4d520d4 data/presets/README: some typo fixes

Thank you!

@bkil bkil deleted the f/present_wlan_camera_contact branch November 19, 2016 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants