Fixed click counter persisting

[ajlomagno]

Fixes #4605

The code that controls the left click and right click portions of the welcome walkthrough removes the click counter element upon successfully clicking the required 5 times then moving onto the next chapter of the walkthrough. It does not take into account the possibility of the user clicking onto a later portion of the walkthrough while the clicking portions still have not been completed, skipping the deletion of the element altogether.

This fix adds a line to curtain.js that deletes any leftover counter elements when constructing the new tooltip.

[bhousel]

This fix adds a line to curtain.js that deletes any leftover counter elements when constructing the new tooltip.

Great! It looks ok - would it work if the removal code is moved to here instead?:

iD/modules/ui/intro/welcome.js

Lines 146 to 148 in 8720f7e

	chapter.exit = function() {
	listener.off();
	};

Each chapter has an exit method that is called when the user leaves that chapter, so I think it makes more sense for cleanup code to be there. It's not really the curtain's job to clean up stray DOM elements.

[ajlomagno]

That sounds like a much better way to fix this. I originally was looking for a way to contain the cleanup code within that chapter but I seemed to have missed the exit method.

I'll make a new commit very soon and we can take another look at it. Thanks!

[ajlomagno]

@bhousel I fixed up this pr with what you mentioned earlier on. I believe it's good to go now.

[bhousel]

Thanks! yay first-time contributor!