Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load WMS tiles if EPSG:3857 (or equivalent) is supported by source #4814

Merged
merged 1 commit into from
Mar 1, 2018

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented Feb 17, 2018

partially fixes #1141.

tyrasd referenced this pull request in osmlab/editor-layer-index Feb 19, 2018
although it doesn't seem to advertise that projection at the moment in its GetCapabilities response 🤷
@bhousel
Copy link
Member

bhousel commented Feb 19, 2018

This looks great @tyrasd - is it still a WIP?

It looks like you are planning to replace the '{proj}' with whichever supported projection editor-layer-index contains (currently hardcoded to 'EPSG:3857', which is the most common anyway).

@tyrasd
Copy link
Member Author

tyrasd commented Feb 20, 2018

is it still a WIP? It looks like you are planning to replace the '{proj}' with whichever supported projection editor-layer-index contains (currently hardcoded to 'EPSG:3857', which is the most common anyway).

Yeah, I'd like to still fix that hardcoded EPSG code there (there might be some obscure WMS services just supporting for example EPSG:900913 but not EPSG:3857).

Also, before we merge/release this, it would be good if we checked the respective WMS layers in ELI and add missing information like geographic extent – I think I saw quite a few of these claiming to be world-wide ("geometry": null) which actually aren't.

@tyrasd tyrasd removed the wip Work in progress label Feb 25, 2018
@tyrasd
Copy link
Member Author

tyrasd commented Feb 25, 2018

I'd say this can be merged now.

@bhousel
Copy link
Member

bhousel commented Mar 1, 2018

Awesome @tyrasd - this is going to open up lots more imagery available for use in iD.. thank you!
I'm going to merge and add some test for the token replacement..

@bhousel bhousel merged commit 67c2dec into master Mar 1, 2018
@bhousel bhousel deleted the wms-tiles branch March 1, 2018 20:16
@bhousel bhousel mentioned this pull request Mar 1, 2018
bhousel added a commit that referenced this pull request Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WMS support
2 participants